Skip to content

EDS - Add CloseSend call to BackfilledStream#545

Draft
friedemannf wants to merge 1 commit into
mainfrom
eds-stream-closesend
Draft

EDS - Add CloseSend call to BackfilledStream#545
friedemannf wants to merge 1 commit into
mainfrom
eds-stream-closesend

Conversation

@friedemannf
Copy link
Copy Markdown
Member

@friedemannf friedemannf commented May 27, 2026

For consistency reasons, add a stream.CloseSend() call to the BackfilledStream's ReceiveFromStream.

According to this grpc-go commit, this doesn't seem to be actually needed, since the only two cases in which this is actually called are:

  1. The stream has been read until Recv() returns a non-nil error
  2. The context is cancelled, which is the same context that's passed to NewClientStream via getStreamWithRetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant