passthrough all custom attributes to slurm job#5
Merged
Conversation
we should allow for any arbitrary custom attributes, this will raise a ValidationError. in the next commit we will catch the validation error and throw a 422
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b65ad7e9c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
swelborn
force-pushed
the
passthru-custom-attr
branch
3 times, most recently
from
8c37470 to
b65ad7e
Compare
Merged
swelborn
force-pushed
the
passthru-custom-attr
branch
from
b65ad7e to
19e5a9f
Compare
swelborn
force-pushed
the
passthru-custom-attr
branch
from
19e5a9f to
e67226c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we send in custom attributes, we should pass them through to be validated by the slurm job model. this way, people can do whatever they are used to and we can support anything in custom attributes. the code doesn’t have to change if the slurm interface changes this way.
we have to make a subclass with extra=forbid because otherwise these would be ignored leaving the user confused.
This is part 1 of 2 in a stack made with GitButler: