fix: improve confirm prompt button contrast in ThemeSurvey#572
Closed
sridhar-3009 wants to merge 1 commit into
Closed
fix: improve confirm prompt button contrast in ThemeSurvey#572sridhar-3009 wants to merge 1 commit into
sridhar-3009 wants to merge 1 commit into
Conversation
ThemeSurvey did not set FocusedButton/BlurredButton styles, so it fell through to ThemeBase defaults: black-on-white for selected and white-on- black for unselected. These look nearly identical in many terminal themes and make it hard to tell which button (Yes/No) is currently active. Add explicit styles to themeSurvey: - FocusedButton: blue, bold — clearly selected - BlurredButton: gray, no bold — clearly inactive The blue matches the existing SelectSelector/SelectedOption color used throughout ThemeSurvey, making the confirm prompt visually consistent with the rest of the survey UI. Fixes slackapi#562
|
Thanks for the contribution! Before we can merge this, we need @sridhar-3009 to sign the Salesforce Inc. Contributor License Agreement. |
Member
|
👋 Hey @sridhar-3009! Thanks for sending this in I think we should close #562 with #564! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #562.
ThemeSurveydid not setFocusedButtonorBlurredButtonstyles, so it fell through toThemeBasedefaults:In many terminal color schemes these look nearly identical, making it unclear which Yes/No button is currently selected.
Fix
Add explicit
FocusedButtonandBlurredButtonstyles inthemeSurvey:SelectSelector/SelectedOptioncolor used throughoutThemeSurvey, visually consistent.The contrast no longer depends on terminal background color.