fix: correct SlackListsItemFieldMessage type - #2722
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
…ssage and array
The message field in Slack Lists API can return either:
- A single message object: "message": {"text":"hello", "ts": "123.456"}
- An array of message objects: "message":[{"text": "a"}, {"text":"b"}]
Previously the type was incorrectly defined as string[] which doesn't match
the API response shape.
Fixes slackapi#2598
|
Thanks for the contribution! Before we can merge this, we need @dajiaohuang to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SlackListsItemFieldMessage interface incorrectly defined the message field as string[]. However, the Slack API can return the message field as either a single message object or an array of message objects.
Fix
This PR introduces a new SlackListsItemMessage interface and updates SlackListsItemFieldMessage to use a union type.
References
Fixes #2598