feat: add chat stream helpers#1595
Closed
Cr1stal wants to merge 2 commits into
Closed
Conversation
Contributor
|
Closing since this is a duplicate of #1545 |
Author
|
@WilliamBergamin Thanks, that makes sense. I opened this PR only because I could not push the cleaned-up/squashed version directly to For reference, the cleaned branch is here: It keeps the same intent but reduces the branch to two commits:
If #1545 should remain the canonical PR, could someone with push access either update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a structured helper API for the Slack chat stream methods.
This is a cleaned-up follow-up to #1545 with a smaller review surface:
ChatStreamandAsyncChatStreamfacades forchat.startStream,chat.appendStream, andchat.stopStream.User/developer impact: callers can work with Slack chat streams through a small stateful helper instead of manually coordinating method calls and stream timestamps.
Validation:
./mvnw -pl slack-api-client test -Dtest=test_locally.api.methods.ChatStreamTest,test_locally.api.methods.AsyncChatStreamTestCategory (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.