Fix alias case sensitivity for table aliases, improve bindings, support where() closure didn't add any criteria (empty closure) #164
Open
mean-cj wants to merge 6 commits into
Open
Conversation
The table alias is currently forced to lowercase, which limits flexibility.
Fixed the way bindings are merged for Raw values.
->where(function ($q) {
// can empty
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving alias handling and fixing binding issues in the query builder. The most significant changes address how table aliases are managed (removing forced lowercasing), correct how bindings are merged for raw values, and enhance criteria building logic for nested queries.
Alias handling improvements:
aliasmethod ofQueryBuilderHandlerand related adapter methods, ensuring aliases retain their original casing throughout query construction. [1] [2] [3]Binding and criteria logic fixes:
Rawvalues in bothdoInsertandgetUpdateStatementmethods inBaseAdapter, ensuring all bindings are properly included usingarray_merge. [1] [2]Bindings Handling Fixes:
array_mergein both insert and update operations, ensuring all bindings are included and preserving the correct order. [1] [2]