Drop node-stream-zip, extract via system tar#24
Closed
soulgalore wants to merge 1 commit into
Closed
Conversation
The only runtime dependency was node-stream-zip, used to extract the edgedriver .zip into vendor/. macOS, Linux, and Windows 10 build 17063+ all ship a tar that understands .zip (bsdtar on macOS and Windows, GNU tar on Linux), so a plain tar -xf replaces the JS lib. Same files end up in vendor/, including the Driver_Notes/ folder; the tolerant credits.html cleanup stays. Why: keeps the install surface as small as possible. node-stream-zip hasn't shipped since 2022 and removing it leaves the package with zero runtime dependencies. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only runtime dependency was node-stream-zip, used to extract the
edgedriver .zip into vendor/. macOS, Linux, and Windows 10 build
17063+ all ship a tar that understands .zip (bsdtar on macOS and
Windows, GNU tar on Linux), so a plain tar -xf replaces the JS lib.
Same files end up in vendor/, including the Driver_Notes/ folder; the
tolerant credits.html cleanup stays.
Why: keeps the install surface as small as possible. node-stream-zip
hasn't shipped since 2022 and removing it leaves the package with
zero runtime dependencies.
Co-authored-by: Claude noreply@anthropic.com