Modernize install: drop node-downloader-helper, fix error handling#22
Merged
Conversation
Mirror the chromedriver install rewrite on edgedriver: replace the node-downloader-helper runtime dep with native fetch + stream pipeline (Node 22+), and stop swallowing failures — install now exits non-zero with a clear message instead of being silently logged. Microsoft has also stopped shipping Driver_Notes/credits.html in some recent edgedriver archives, so unlink that file tolerantly (ENOENT is no longer an error) — previously a missing credits.html would have thrown after a successful download/extract. Drops the now-unused request/semver dev deps and the dead eslint-check script that referenced a non-existent .eslintrc.js. Bumps engines.node to >=22 and the CI matrix to Node 22 to match. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the chromedriver install rewrite on edgedriver: replace the
node-downloader-helper runtime dep with native fetch + stream pipeline
(Node 22+), and stop swallowing failures — install now exits non-zero
with a clear message instead of being silently logged.
Microsoft has also stopped shipping Driver_Notes/credits.html in some
recent edgedriver archives, so unlink that file tolerantly (ENOENT is
no longer an error) — previously a missing credits.html would have
thrown after a successful download/extract.
Drops the now-unused request/semver dev deps and the dead
eslint-check script that referenced a non-existent .eslintrc.js. Bumps
engines.node to >=22 and the CI matrix to Node 22 to match.
Co-authored-by: Claude noreply@anthropic.com