Skip to content

Update "id" schema from number to integer #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cosimon wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update "id" schema from number to integer #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4571220
Update "id" schema from number to integer
cosimon Jun 24, 2026
bbb52a8
Testing pull_requests id as number
cosimon Jun 24, 2026
1795ac0
Update pull_requests id schema
cosimon Jul 9, 2026
44c029c
trigger ci
cosimon Jul 13, 2026
3a51301
Change PR id to string
cosimon Jul 13, 2026
4d274ea
Testing changes
cosimon Jul 13, 2026
e312e95
wip
cosimon Jul 13, 2026
e1cc876
wip
cosimon Jul 13, 2026
7715748
Fix pr_commits schema and revert testing related changes
cosimon Jul 13, 2026
bdf9ad1
Bump to v4.0.0 and update changelog
cosimon Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

# 4.0.0
* Updates to schemas changing many id fields from "number" to "integer" [#232](https://github.com/singer-io/tap-github/pull/232)

# 3.4.0
* Exclude 403-forbidden streams from discovery [#229](https://github.com/singer-io/tap-github/pull/229)
* Bump dependencies for compliance
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

setup(name='tap-github',
version='3.4.0',
version='4.0.0',
description='Singer.io tap for extracting data from the GitHub API',
author='Stitch',
url='http://singer.io',
Expand Down
4 changes: 2 additions & 2 deletions tap_github/schemas/commit_comments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -41,7 +41,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
2 changes: 1 addition & 1 deletion tap_github/schemas/commits.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"type": ["null", "integer"]
},
"id": {
"type": ["null", "string"]
"type": ["null", "integer"]
},
"updated_at": {
"type": ["null", "string"],
Expand Down
8 changes: 4 additions & 4 deletions tap_github/schemas/events.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"login": {
"type": ["null", "string"]
Expand All @@ -31,7 +31,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"org": {
"type": ["null", "object"],
Expand All @@ -43,7 +43,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"login": {
"type": ["null", "string"]
Expand Down Expand Up @@ -1036,7 +1036,7 @@
"type": ["null", "object"],
"properties": {
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"name": {
"type": ["null", "string"]
Expand Down
2 changes: 1 addition & 1 deletion tap_github/schemas/issue_labels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
4 changes: 2 additions & 2 deletions tap_github/schemas/issue_milestones.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -44,7 +44,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
6 changes: 3 additions & 3 deletions tap_github/schemas/project_cards.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand All @@ -41,7 +41,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -117,4 +117,4 @@
"type": ["null", "string"]
}
}
}
}
2 changes: 1 addition & 1 deletion tap_github/schemas/project_columns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
6 changes: 3 additions & 3 deletions tap_github/schemas/projects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -44,7 +44,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -114,4 +114,4 @@
"type": ["null", "boolean"]
}
}
}
}
2 changes: 1 addition & 1 deletion tap_github/schemas/pull_requests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"type": ["string"]
},
"id": {
"type": ["null", "string"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
4 changes: 2 additions & 2 deletions tap_github/schemas/releases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"type": ["string"]
},
"id": {
"type": ["null", "string"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down Expand Up @@ -189,4 +189,4 @@
"type": ["null", "string"]
}
}
}
}
2 changes: 1 addition & 1 deletion tap_github/schemas/team_members.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
2 changes: 1 addition & 1 deletion tap_github/schemas/teams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": ["null", "string"]
},
"id": {
"type": ["null", "number"]
"type": ["null", "integer"]
},
"node_id": {
"type": ["null", "string"]
Expand Down
1 change: 1 addition & 0 deletions tap_github/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ def get_child_records(self,
with singer.Transformer() as transformer:

rec = transformer.transform(records, stream_catalog['schema'], metadata=metadata.to_map(stream_catalog['metadata']))

if child_object.tap_stream_id in selected_stream_ids and records.get(child_object.replication_keys, start_date) >= child_bookmark_value :

singer.write_record(child_object.tap_stream_id, rec, time_extracted=extraction_time)
Expand Down
1 change: 1 addition & 0 deletions tap_github/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ def do_sync(catalog, streams_to_sync, selected_stream_ids, client, start_date, s
if stream_id in streams_to_sync and not stream_obj.parent:
write_schemas(stream_id, catalog, selected_stream_ids)
update_currently_syncing(state, stream_id)
LOGGER.info("Starting sync of stream: %s", stream_id)

state = stream_obj.sync_endpoint(client = client,
state = state,
Expand Down