[Sim] guard malformed expression parsing#11460
Open
Harmenszoon wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pet.any.activeexpression parsing so malformedpet.anyno longer reads past the split-vector bounds.actors.<name>.<expr>expression parsing against missing actors by checking the looked-up actor pointer instead of the sim target.Details
Both changes route malformed expressions through the normal invalid-expression initialization error path instead of undefined behavior or an access violation.
pet.any.active.<trailing>is also no longer silently accepted aspet.any.active; the valid generated form remainspet.any.active.Validation
build-codexwith VS2022 DevCmd + CMake.simc hunter=test spec=beast_mastery level=90 race=orc role=attack position=ranged_back load_default_gear=1 load_default_talents=1 iterations=1 output=NUL actions=variable,name=bad,value=pet.anynow exits 30 with a normal initialization error.value=pet.any.activeexits 0.value=actors.nope.health.pctnow exits 30 with a normal initialization error instead of access violation.value=actors.test.health.pctexits 0.simc display_build=2 output=NULexits 0.simc profiles/CI.simc iterations=1 cleanup_threads=1 output=NULexits 0 with existing baseline profile/data warnings.git diff --check origin/midnight...HEADpassed.