[Action] fix report-only variable actions#11456
Open
Harmenszoon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variable,op=reportas a report configuration action instead of an executable APL action.OPERATION_REPORTas a no-op if it ever reachesvariable_t::execute().Details
op=reportonly enables sample-sequence reporting for the named variable. Before this change it was still added to the foreground action list, so a standalone report action could execute and hit the debugassert(0)path invariable_t::execute().Marking the action as
backgroundmatches the existing action contract for actions that should not be directly executed from an action list, and keeps the report-only action out of variable mutation/constant tracking.Testing
simc.exe build-codex\variable_report_repro.simc iterations=1 max_time=1 output=NUL cleanup_threads=1simc.exe build-codex\variable_report_sequence.simc iterations=1 max_time=2 report_details=1 output=build-codex\variable_report_sequence.txt html=build-codex\variable_report_sequence.html cleanup_threads=1VAR [set]for the reported variable.simc.exe profiles\CI.simc iterations=10 output=build-codex\ci_variable_report_validation.txt cleanup_threads=1git diff --check