Skip to content

feat(oci): add Resource Manager integration - #7546

Open
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
feat/oci-resource-manager
Open

feat(oci): add Resource Manager integration#7546
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
feat/oci-resource-manager

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add 33 native OCI Resource Manager tools and nine server selectors for stacks, configuration sources, jobs, plan/apply/destroy and rollback, logs, outputs, state, and drift work requests.
  • Reuse the OCI service-account credential provider and signed client. Jobs return identifiers/status; destructive actions require explicit confirmation. Authorized downloads return stored file references, with deliberate sensitive-value projections.
  • Stacked on feat(oci): add native foundation #7444 (feat/oci-foundation, 3fa59e758f5d282e95978aca7482a91a4f3dcee5). This PR contains only the Resource Manager child.

Type of Change

  • New integration

Testing

  • Added focused request/source, file-authorization/output, projection, and selector tests.
  • Independent validate-integration review accepted the final child together with its foundation base.
  • GitHub Test and Build passed at 463569d3d271c3c5650bcc33df47ee167c875e44: lint, audits, type checks, all test shards, and the production build. No local tests, lint, builds, or checks were run. Formatting was applied from a GitHub-produced patch; the final PR has no workflow changes.
  • No live OCI tenant operations or Terraform execution performed.

Compatibility notes

  • Oracle runs Terraform; Sim does not introduce a local runner.
  • Disable block retries for mutations. The existing generic executor drops tool-level nonretryable classification; this shared issue is outside this integration PR. A transport retry token does not guarantee safe whole-block replay.
  • File transfers are bounded and buffered; large state imports can transiently use several times the file size in memory.
  • Detailed-log IAM mappings and variable removal/merge semantics are not fully specified by the inspected Oracle documentation; no undocumented behavior is assumed.

Checklist

  • Self-reviewed the integration against official Oracle API contracts and existing integration patterns
  • Reused the existing icon and generated documentation/catalog machinery
  • GitHub CI passed
  • Greptile confidence 5/5 on the final commit; zero unresolved review threads

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 6, 2026 1:06am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a native OCI Resource Manager integration covering stack management, Terraform jobs, state and configuration transfers, drift detection, logs, outputs, work requests, and dynamic selectors.

Changes since the previous review primarily expand generated nested output documentation and reformat the integration implementation without materially changing its execution behavior.

  • Registers 33 Resource Manager tools and their workflow block configuration.
  • Adds OCI stack, job, rollback-plan, provider, template, and work-request selectors.
  • Reuses authorized OCI service-account credentials and signed requests.
  • Preserves explicit confirmations for destructive infrastructure and state operations.
  • Returns authorized downloads as stored file references and gates sensitive projections behind explicit inputs.

Confidence Score: 5/5

The changes since the previous review appear safe to merge, with no new actionable defects or outstanding prior findings identified.

The previously disputed drift-request finding was correctly conceded and resolved because OCI specifies the bodyless POST operation, while the declaration comment now uses TSDoc and its thread is resolved. The subsequent changes preserve request construction, validation, authorization, confirmation gates, and sensitive projections while expanding generated output documentation.

Important Files Changed

Filename Overview
apps/sim/lib/internal/oci-resource-manager/operations.ts Builds the OCI requests and applies bounded projections, confirmation-dependent behavior, and authorized file handling.
apps/sim/lib/internal/oci-resource-manager/input.ts Defines operation-specific schemas and cross-field validation for scopes, confirmations, projections, and log modes.
apps/sim/lib/internal/oci-resource-manager/client.ts Implements signed Resource Manager requests, response-size limits, retry behavior, and provider response parsing.
apps/sim/blocks/blocks/oci_resource_manager.ts Exposes the integration's operations, conditional controls, selector dependencies, canonical parameter mapping, and outputs.
apps/sim/tools/oci_resource_manager/types.ts Expands formatting and generated nested output metadata without materially changing the existing contracts.
apps/sim/lib/selectors/server/providers/oci-resource-manager.ts Supplies bounded Resource Manager selectors using the integration's authorized server-side execution path.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  User[Workflow configuration] --> Block[OCI Resource Manager block]
  Block --> Tool[Selected Resource Manager tool]
  Tool --> Validation[Input and confirmation validation]
  Validation --> Auth[Authorized OCI service-account credential]
  Auth --> Client[Signed OCI Resource Manager client]
  Client --> OCI[Oracle Resource Manager API]
  OCI --> Projection[Bounded response projection]
  Projection --> Structured[Structured workflow output]
  Projection --> StoredFile[Authorized stored file reference]
Loading

Reviews (3): Last reviewed commit: "feat(oci): add Resource Manager integrat..." | Re-trigger Greptile

Comment thread apps/sim/lib/internal/oci-resource-manager/operations.ts Outdated
Comment thread apps/sim/lib/internal/oci-resource-manager/input.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant