improvement(ui): unbold the app, align the folder chevron, tidy the feedback modal - #6400
Conversation
…eedback modal #6241 deleted the --font-weight-* scale from globals.css and its fontWeight mapping from tailwind.config.ts. font-medium jumped 440/480 -> 500, font-semibold 500/550 -> 600, and body dropped 420 -> 400, so every existing call site snapped a full step above a body that got lighter. #6291 fixed packages/emcn only; the product call sites were left behind. Strips the weight class from body, label, row, and heading text across app/workspace, ee, workflow-renderer, the non-workspace route groups, and components/ui/button.tsx, whose buttonVariants injected font-medium into every consumer. Keeps it only where it steps up: markdown/prose bold and micro avatar initials. Also aligns the workflow-tree folder chevron to the sidebar section header (14px, 150ms), and on the feedback modal drops the prompt line above the Feedback field and re-homes Copy ID as a footer secondary action.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Feedback modal ( Comment-only tweak in Reviewed by Cursor Bugbot for commit 1ead892. Configure here. |
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1ead892. Configure here.
Greptile SummaryThis PR restores the intended normal font weight across product UI after the typography scale changed, aligns the workflow-folder chevron with the existing sidebar convention, and reorganizes the feedback modal around canonical ChipModal fields and footer actions.
Confidence Score: 5/5The PR appears safe to merge, with the reviewed changes consistently limited to intended presentation and modal-action placement. Shared typography now follows the documented normal-weight contract, the feedback copy action preserves its behavior and state lifecycle in the footer, and the chevron adjustment does not alter interaction logic.
|
| Filename | Overview |
|---|---|
| apps/sim/components/ui/button.tsx | Removes the shared medium-weight default so button text inherits the repository’s canonical normal typography. |
| apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx | Replaces the feedback modal’s custom prompt/copy row with a canonical field and footer secondary action without changing copy or dismissal behavior. |
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/folder-item/folder-item.tsx | Aligns the folder disclosure chevron’s size and transition duration with the established sidebar convention. |
| packages/workflow-renderer/src/note/note-block-view.tsx | Removes unintended weight utilities from workflow-renderer note chrome while retaining explicit semantic emphasis. |
Reviews (1): Last reviewed commit: "improvement(ui): unbold the app, align t..." | Re-trigger Greptile
Six conflicts, all one cause: staging's unbolding sweep (#6400) landed on code this branch had moved out of the route tree. Resolved by keeping this branch's structure and replaying every one of staging's 21 `font-medium` removals at the element's new home — 16 applied, the rest already absorbed by the auto-merge. Verified none of the strings staging unbolded is still bold anywhere in the tree. One deliberate deviation: staging rewrote the file-preview fallback as `text-[14px]`, which the styling rule forbids (font-size only, inherits the wrong line-height). Took staging's intent — dropping `font-medium` — and kept the named `text-sm`, which is the same 14px. `base.tsx` and `file-viewer.tsx` came back as delete/modify conflicts because they no longer exist here; their changes were ported into `document-list.tsx` and the file-view unit rather than dropped. Suite: 20951 passed. R6/R3c 0, 23 audits green.
…e menus like the sidebar (#6447) * improvement(ui): consolidate the disclosure chevron and order resource menus like the sidebar #6400 aligned the workflow-tree folder chevron to the sidebar section header (16px/100ms -> 14px/150ms) but left the literal hand-copied in three files, so the next edit could drift them apart again. Extracts `disclosureChevronClass` into chip-chrome as the single source and points the section header and both sidebar trees at it. Adds `chipIconSlotClass` for the 16px slot that ChipChevronDown, ChipSelect, ChipDropdown and ChipDatePicker each re-derived. Both Back buttons rendered a ChevronDown rotated 90deg at 10px — wrong glyph, and 4px under every other chevron in the app; they are now ChevronLeft at 14px in that shared slot. The sidebar file tree drew hand-inlined SVGs at strokeWidth 2 next to the workflow tree's emcn icons at 1.55, so the two trees showed different folder glyphs; both now use the emcn set. Its file rows also indented by the chevron's width alone, landing their icon 4px left of a folder's and 2px smaller despite the comment claiming they lined up — they now clear the chevron plus the row gap at the same 16px size. Separately, the chat `+`/`@` resource menus rendered every foldered family as a submenu and only then the flat ones, which pinned Workflows to the top regardless of any ordering. Adds `RESOURCE_MENU_ORDER` mirroring the sidebar top-down and merges both kinds into one ordered pass, so the menus read Integrations, Chats, Tables, Files, Knowledge Bases, Logs, Workflows, then Browser and Terminal on desktop. Documents the general rule in .claude/rules/sim-list-ordering.md. * improvement(ui): order the remaining resource menus the way the user reads them An audit of every menu, tab strip, and context menu against the surface the user already reads those items on turned up six more divergences. The table row context menu put View execution before the Run/Re-run/Stop cluster while the action bar puts it after, so the same four actions read in two orders; the menu now follows the bar. The Files, Tables, and Knowledge empty-space create menus were each the exact reverse of their own page header, and each named the same action differently ("Create table" vs "New table", "Add knowledge base" vs "New base") — reversed to match, labels unified. Recently Deleted led with Workflows and buried Chats last, and put Knowledge Bases ahead of Files; it now follows the sidebar after the default All tab. The command palette hoisted Workflows from last to second for the same reason, and is now in sidebar order too. Chats stays first in both, so the palette's Enter default is unchanged. Drops the unused RESOURCE_TYPES export: nothing consumed it, and its declaration order was nearly the inverse of RESOURCE_MENU_ORDER, so the first consumer to map it would have silently rendered a backwards menu. Not included: buildUnifiedSettingsNavigation never applies its own unified.order and returns registry declaration order instead. Nothing user-visible today (the sidebar re-sorts before rendering) but navigation.test.ts pins the unsorted order as canonical, so fixing it means changing that test — worth doing deliberately rather than inside this PR.
1 participant
Summary
--font-weight-*scale fromglobals.cssand itsfontWeightmapping fromtailwind.config.ts, sofont-mediumjumped 440/480 → 500,font-semibold500/550 → 600, and body dropped 420 → 400. Nothing was restyled — the utility's meaning changed under ~300 call sites at once. improvement(emcn): let every primitive inherit the document font weight #6291 fixedpackages/emcnonly; every product call site was left behindapp/workspace,ee,workflow-renderer, theunsubscribe/invite/f/[token]/oauth-error/_shell/playground/(interfaces)route groups, andcomponents/ui/button.tsx— whosebuttonVariantsinjectedfont-mediuminto every consumer, the single widest source.claude/rules/sim-styling.md: markdown/prose bold (<strong>,prose-strong:,[&_strong]:, markdown headings and<th>) and micro avatar initials / tile glyphs attext-[7px]/[8px]/microsize-[16px]/duration-100→size-[14px]/duration-150. The files-tree chevron was already on spec, so both trees now agreesecondaryActionschip. That also removes a hand-rolled field row fromChipModalBody, which CLAUDE.md prohibits — it sat atpx-2instead of the field's effectivepx-4, misaligned with the header and footer guttersType of Change
Testing
Tested manually.
Verification beyond that:
bunx turbo run type-check— 23/23 pass;biome checkclean acrossapps+packages(11 pre-existing warnings, all in untouched files)git grepfor a weight class inside a conditional on the base commit returns zero — there was noisActive && 'font-medium'anywhere — so unconditional stripping cannot have erased a selected/hover distinctiongeneral.tsx, the transparent-input + overlay in the MCP form modal), since those drift visibly if only one half changesNot covered, deliberately:
app/(landing)/**,apps/docs,lib/content/mdx.tsxandfaq.tsxcarry the same regression — separate design surface, separate PR.Checklist