Skip to content

chore(gitignore): ignore the repo-root uploads spill directory - #6089

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/gitignore-root-uploads
Jul 30, 2026
Merged

chore(gitignore): ignore the repo-root uploads spill directory#6089
waleedlatif1 merged 1 commit into
stagingfrom
chore/gitignore-root-uploads

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Running the test suite from the repo root leaves ~40 untracked uploads/execution/**/large-value-*.json artifacts; nothing ignored them
  • UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads'), so it follows the cwd — under turbo run test the cwd is apps/sim and that package's /uploads rule catches it, but a repo-root invocation escapes it
  • Added an anchored /uploads to the root .gitignore. Unanchored uploads/ would also match apps/sim/lib/uploads/ — 61 files of tracked source — and silently ignore anything added there later

Type of Change

  • Bug fix

Testing

Verified both directions: git check-ignore confirms the artifact path is now ignored, and confirms apps/sim/lib/uploads/core/setup.server.ts is still not ignored. bun run lint clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads'), so it follows the cwd
rather than a fixed root. Under turbo run test the cwd is apps/sim and that
package's /uploads rule catches it, but running vitest from the repo root
writes ~40 uploads/execution/**/large-value-*.json files to a path nothing
ignored.

Anchored on purpose: an unanchored uploads/ would also match
apps/sim/lib/uploads/ (61 tracked source files) and silently ignore anything
added there later.
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Jul 30, 2026 3:26am

Request Review

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only ignore rule change; no runtime or application code is modified.

Overview
Adds anchored /uploads to the root .gitignore so test runs that use cwd at the repo root no longer leave untracked uploads/execution/**/large-value-*.json artifacts in git status.

The rule is repo-root only (/uploads), with comments explaining that upload spill paths follow process.cwd() and that an unanchored uploads/ pattern would wrongly ignore tracked code under apps/sim/lib/uploads/.

Reviewed by Cursor Bugbot for commit b2f3e84. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an anchored root /uploads entry to .gitignore so test spill files under the repo-root uploads/ directory are ignored without matching tracked source under apps/sim/lib/uploads/.

  • Anchors ignore to repository-root uploads/ only
  • Documents cwd-dependent UPLOAD_DIR_SERVER spill behavior vs apps/sim package ignore

Confidence Score: 5/5

Safe to merge; the change only ignores the intended root uploads spill directory and does not alter runtime behavior.

Single anchored gitignore rule matches the described cwd-dependent upload spill path and preserves tracked source under nested uploads packages.

Important Files Changed

Filename Overview
.gitignore Anchored /uploads ignore for repo-root upload spill; correctly avoids unanchored uploads/ that would hide tracked apps/sim/lib/uploads/ source.

Reviews (1): Last reviewed commit: "chore(gitignore): ignore the repo-root u..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 8260891 into staging Jul 30, 2026
20 of 21 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/gitignore-root-uploads branch July 30, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant