chore(gitignore): ignore the repo-root uploads spill directory - #6089
Conversation
UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads'), so it follows the cwd rather than a fixed root. Under turbo run test the cwd is apps/sim and that package's /uploads rule catches it, but running vitest from the repo root writes ~40 uploads/execution/**/large-value-*.json files to a path nothing ignored. Anchored on purpose: an unanchored uploads/ would also match apps/sim/lib/uploads/ (61 tracked source files) and silently ignore anything added there later.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The rule is repo-root only ( Reviewed by Cursor Bugbot for commit b2f3e84. Configure here. |
Greptile SummaryAdds an anchored root
Confidence Score: 5/5Safe to merge; the change only ignores the intended root uploads spill directory and does not alter runtime behavior. Single anchored gitignore rule matches the described cwd-dependent upload spill path and preserves tracked source under nested uploads packages.
|
| Filename | Overview |
|---|---|
| .gitignore | Anchored /uploads ignore for repo-root upload spill; correctly avoids unanchored uploads/ that would hide tracked apps/sim/lib/uploads/ source. |
Reviews (1): Last reviewed commit: "chore(gitignore): ignore the repo-root u..." | Re-trigger Greptile
Summary
uploads/execution/**/large-value-*.jsonartifacts; nothing ignored themUPLOAD_DIR_SERVERisjoin(process.cwd(), 'uploads'), so it follows the cwd — underturbo run testthe cwd isapps/simand that package's/uploadsrule catches it, but a repo-root invocation escapes it/uploadsto the root.gitignore. Unanchoreduploads/would also matchapps/sim/lib/uploads/— 61 files of tracked source — and silently ignore anything added there laterType of Change
Testing
Verified both directions:
git check-ignoreconfirms the artifact path is now ignored, and confirmsapps/sim/lib/uploads/core/setup.server.tsis still not ignored.bun run lintclean.Checklist