Skip to content

fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jul 30, 2026
+8 −3
Merged

fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary #6082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/sim/lib/execution/remote-sandbox/pi-lifetime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,14 @@ describe('resolvePiRunLifetimeMs', () => {
'@/lib/execution/remote-sandbox/pi-lifetime'
)

// The async ceiling is 90 minutes, above what E2B will grant, so the
// provider cap still wins.
const timeout = createTimeoutAbortController(90 * 60 * 1000)
// The deadline must be strictly past the ceiling for the ceiling to win.
// Passing exactly `PI_SANDBOX_MAX_LIFETIME_MS` made this a coin flip: the
// remaining budget is `deadline - Date.now()`, so it decays below the ceiling
// as soon as one millisecond of test time elapses, and `Math.min` then
// returns the remaining budget instead (`expected 5399999 to be 5400000`).
// An equal deadline also isn't the case the name describes — the run has to
// outlive the ceiling, not match it.
const timeout = createTimeoutAbortController(PI_SANDBOX_MAX_LIFETIME_MS + 60_000)

expect(resolvePiRunLifetimeMs(timeout.signal)).toBe(PI_SANDBOX_MAX_LIFETIME_MS)
timeout.cleanup()
Expand Down
Loading