Skip to content

improvement(pii): clarify custom regex replacement placeholder - #5975

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/pii-label-followup
Jul 27, 2026
Merged

improvement(pii): clarify custom regex replacement placeholder#5975
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/pii-label-followup

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • The replacement field in the PII custom regex editor showed EMPLOYEE_ID as its placeholder, which read like a specific example rather than a format hint
  • Changed it to SUBSTITUTION_TEXT so it matches the sibling Name / Pattern (regex) placeholders

Left EMPLOYEE_ID where it's genuinely an example in prose (Data Retention tooltip, docs, TSDoc) — those explain the EMPLOYEE_ID → <EMPLOYEE_ID> transform.

Type of Change

  • Improvement

Testing

Tested manually. bun run lint and the full audit suite (boundaries, api-validation:strict, utils, zustand-v5, react-query, client-boundary, bare-icons, icon-paths, realtime-prune, skills:check, agent-stream-docs:check) all pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 27, 2026 5:35pm

Request Review

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single placeholder string change with no runtime or data-handling impact.

Overview
Updates the replacement field placeholder in CustomPatternsEditor from EMPLOYEE_ID to SUBSTITUTION_TEXT, so it reads as a format hint alongside Name and Pattern (regex) instead of looking like a fixed example value.

No behavior, validation, or API changes—copy-only in the PII custom regex UI.

Reviewed by Cursor Bugbot for commit d096558. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Clarifies the custom PII pattern editor’s replacement-field hint.

  • Replaces the EMPLOYEE_ID placeholder with the format-oriented SUBSTITUTION_TEXT placeholder.

Confidence Score: 5/5

The PR appears safe to merge because it only clarifies static placeholder text.

The changed string is displayed only when the replacement input is empty and does not alter the controlled value, event handling, or persisted custom PII configuration.

Important Files Changed

Filename Overview
apps/sim/components/pii/custom-patterns-editor.tsx Updates only the replacement input’s placeholder text without changing input state, validation, or replacement behavior.

Reviews (1): Last reviewed commit: "improvement(pii): clarify custom regex r..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 49adf91 into staging Jul 27, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/pii-label-followup branch July 27, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant