improvement(pii): clarify custom regex replacement placeholder - #5975
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview No behavior, validation, or API changes—copy-only in the PII custom regex UI. Reviewed by Cursor Bugbot for commit d096558. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryClarifies the custom PII pattern editor’s replacement-field hint.
Confidence Score: 5/5The PR appears safe to merge because it only clarifies static placeholder text. The changed string is displayed only when the replacement input is empty and does not alter the controlled value, event handling, or persisted custom PII configuration.
|
| Filename | Overview |
|---|---|
| apps/sim/components/pii/custom-patterns-editor.tsx | Updates only the replacement input’s placeholder text without changing input state, validation, or replacement behavior. |
Reviews (1): Last reviewed commit: "improvement(pii): clarify custom regex r..." | Re-trigger Greptile
Summary
EMPLOYEE_IDas its placeholder, which read like a specific example rather than a format hintSUBSTITUTION_TEXTso it matches the siblingName/Pattern (regex)placeholdersLeft
EMPLOYEE_IDwhere it's genuinely an example in prose (Data Retention tooltip, docs, TSDoc) — those explain theEMPLOYEE_ID → <EMPLOYEE_ID>transform.Type of Change
Testing
Tested manually.
bun run lintand the full audit suite (boundaries, api-validation:strict, utils, zustand-v5, react-query, client-boundary, bare-icons, icon-paths, realtime-prune, skills:check, agent-stream-docs:check) all pass.Checklist