Skip to content

Commit 9a1da09

Browse files
committed
docs(chat): scope the table copy 'complete' comment to the text path
It read as though the whole selection were complete when ids are unloaded, which is now only true of the serialized text — the chip deliberately carries every selected id for the server to re-fetch.
1 parent f82c44e commit 9a1da09

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

  • apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3015,11 +3015,12 @@ export function TableGrid({
30153015

30163016
if (!rowSelectionIsEmpty(rowSel)) {
30173017
e.preventDefault()
3018-
// Only an explicit multi-row selection can carry the chip: a filtered
3018+
// Only an explicit multi-row selection can take this path: a filtered
30193019
// select-all ('all') pages in rows beyond those loaded, which the async
3020-
// path must fetch. For 'some' the fall-through re-reads the same loaded
3021-
// rows (see its `loadRows`), so it never copies more than this does —
3022-
// the selection is complete here even when some ids aren't loaded yet.
3020+
// fall-through must fetch. `complete` refers to the copied TEXT only —
3021+
// for 'some' the fall-through re-reads these same loaded rows (see its
3022+
// `loadRows`), so it can never serialize more than this does. The chip
3023+
// is not bound by that; see `rowIds` below.
30233024
if (rowSel.kind === 'some') {
30243025
const selectedRows = currentRows.filter((row) => rowSelectionIncludes(rowSel, row.id))
30253026
const handled = writeLoadedRowsWithChip({

0 commit comments

Comments
 (0)