Commit f82c44e
committed
fix(chat): reference every selected row in a table chip, not just loaded ones
Cursor Bugbot: for a 'some' row selection the chip's rowIds came from the
loaded-page intersection (currentRows filtered by the selection) rather than
rowSel.ids. The chip carries ids and the server re-fetches them via
getRowsByIds, so a selected row that simply had not been paged into the grid
was silently dropped from the agent's context — select 600 rows with 200
loaded and the agent saw 200. Add to chat had the same loaded-only narrowing
through contextMenuRowIds.
Both now send the full selection, still bounded by MAX_TABLE_SELECTION_ROWS.
Only the pasted text stays limited to loaded rows, which is inherent — there
are no cell values to serialize for a row that has not been fetched.1 parent 7d3d58d commit f82c44e
1 file changed
Lines changed: 15 additions & 2 deletions
Lines changed: 15 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3031 | 3031 | | |
3032 | 3032 | | |
3033 | 3033 | | |
3034 | | - | |
| 3034 | + | |
| 3035 | + | |
| 3036 | + | |
| 3037 | + | |
3035 | 3038 | | |
3036 | 3039 | | |
3037 | 3040 | | |
| |||
3860 | 3863 | | |
3861 | 3864 | | |
3862 | 3865 | | |
3863 | | - | |
| 3866 | + | |
| 3867 | + | |
| 3868 | + | |
| 3869 | + | |
| 3870 | + | |
| 3871 | + | |
| 3872 | + | |
| 3873 | + | |
| 3874 | + | |
| 3875 | + | |
3864 | 3876 | | |
3865 | 3877 | | |
3866 | 3878 | | |
| |||
3889 | 3901 | | |
3890 | 3902 | | |
3891 | 3903 | | |
| 3904 | + | |
3892 | 3905 | | |
3893 | 3906 | | |
3894 | 3907 | | |
| |||
0 commit comments