Conversation
…settled one The converge gate read `status.configuration.name` as the pool's target. MCO only advances that field once the WHOLE pool has finished rolling, so for the duration of a rollout it still names the PREVIOUS render. A node that had already converged on the new render therefore compared unequal and waited for every other node in the pool; on any pool that takes longer than the 240x10s budget the wait expires with "did not converge on MCP config in time" and SPDK never starts. The check also passed for a node still sitting on the old config, which is the opposite of what the gate exists to assert. Read `spec.configuration.name` instead -- the render controller sets it to the target as soon as it renders, so it is correct both mid-rollout and once settled. Lift `_cfg_hash` out of its closure and add `_mcp_target_config` / `_node_carries_config` at module scope so the predicate is reachable from tests. It was previously inline in a 200-line function that also renders templates, creates Jobs and drives three k8s clients, which is why the suite had no reference to machineconfigpool at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…settled one
The converge gate read
status.configuration.nameas the pool's target. MCO only advances that field once the WHOLE pool has finished rolling, so for the duration of a rollout it still names the PREVIOUS render. A node that had already converged on the new render therefore compared unequal and waited for every other node in the pool; on any pool that takes longer than the 240x10s budget the wait expires with "did not converge on MCP config in time" and SPDK never starts. The check also passed for a node still sitting on the old config, which is the opposite of what the gate exists to assert.Read
spec.configuration.nameinstead -- the render controller sets it to the target as soon as it renders, so it is correct both mid-rollout and once settled.Lift
_cfg_hashout of its closure and add_mcp_target_config/_node_carries_configat module scope so the predicate is reachable from tests. It was previously inline in a 200-line function that also renders templates, creates Jobs and drives three k8s clients, which is why the suite had no reference to machineconfigpool at all.