Skip to content

Fixes the lag that happens sometimes when selecting a caret position after changing text. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mach-port-t wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes the lag that happens sometimes when selecting a caret position after changing text. #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
653a7ad
Merge pull request #1 from simonbs/main
mach-port-t Apr 9, 2026
d9cd680
fix: reseting input delegate notification on selection change
mach-port-t Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Runestone/TextView/Core/TextInputView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ final class TextInputView: UIView, UITextInput {
// We will sometimes disable notifying the input delegate when the user enters Korean text.
// This workaround is inspired by a dialog with Alexander Blach (@lextar), developer of Textastic.
if notifyInputDelegateAboutSelectionChangeInLayoutSubviews {
notifyInputDelegateAboutSelectionChangeInLayoutSubviews = false
inputDelegate?.selectionWillChange(self)
inputDelegate?.selectionDidChange(self)
}
Expand Down