Add approx large-integer overflow/boundary test coverage#467
Open
mag123c wants to merge 1 commit into
Open
Conversation
Mirrors the correct-parser long_int_boundaries coverage for the approx-number-parsing feature: exercises the cold parse_large_integer path at its i64::MIN / u64::MAX success boundaries and the Overflow errors just past them. The overflow assertions are gated to the case where neither 128bit (wider target) nor big-int-as-float (float reinterpretation) is enabled. Addresses simd-lite#89.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the #89 error-coverage work after #465 and #466.
What
long_int_boundariestest for theapprox-number-parsingparser, mirroring the correct-parser test.parse_large_integerpath:i64::MIN/u64::MAXsuccess boundaries and theOverflowerrors just past them.128bitnorbig-int-as-floatis enabled, since both change the outcome.Notes
parse_large_integeralready returned these errors, the path just had no test entering it.approx.rsignoresbig-int-as-float, but the gate mirrors the correct-parser test for consistency.cargo test --features approx-number-parsingand--features approx-number-parsing,128bit.