SF-3918 Keep generated draft tab open when navigating chapters - #4077
Open
RaymondLuong3 wants to merge 1 commit into
Open
SF-3918 Keep generated draft tab open when navigating chapters#4077RaymondLuong3 wants to merge 1 commit into
RaymondLuong3 wants to merge 1 commit into
Conversation
RaymondLuong3
added
the
will require testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4077 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 666 666
Lines 43268 43268
Branches 7088 7088
=======================================
+ Hits 35113 35115 +2
+ Misses 6985 6969 -16
- Partials 1170 1184 +14 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps the draft tab open even when navigating between chapters when the draft is already applied. It goes one step further and always keeps the tab open until a user chooses to close it. This makes sense since I do not see why automatically closing tabs is helpful.
This change is