Skip to content

SF-1119 Archive instead of delete questions when book is removed - #4075

Open
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-1119-archive-questions-book-removal
Open

SF-1119 Archive instead of delete questions when book is removed#4075
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-1119-archive-questions-book-removal

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

The sync logic now looks a bit odd with questions being archived and notes being deleted, but I think that actually makes sense because questions are only present in SF, so their deletion is destructive, whereas notes are also present in PT. I'm assuming we're essentially removing the notes from SF, but PT still has them, while the deletion of questions was permanently deleting them from a user's perspective (though I'm guessing ShareDB still had the ops).

Long term it would be nice to have a "deleted" state in SF, in addition to the archive state, and it would make more sense to put them there. In the meantime though, this makes more sense than removing them entirely.

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Aug 27, 2026
@Nateowami
Nateowami deployed to screenshot_diff August 27, 2026 16:44 — with GitHub Actions Active
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.09%. Comparing base (9ea2662) to head (94959e1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...IL.XForge.Scripture/Services/ParatextSyncRunner.cs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4075   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files         666      666           
  Lines       43263    43269    +6     
  Branches     7061     7087   +26     
=======================================
+ Hits        35085    35090    +5     
  Misses       7013     7013           
- Partials     1165     1166    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed will require testing PR should not be merged until testers confirm testing is complete labels Aug 28, 2026
@Nateowami
Nateowami marked this pull request as ready for review August 28, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant