SF-1119 Archive instead of delete questions when book is removed - #4075
Open
Nateowami wants to merge 1 commit into
Open
SF-1119 Archive instead of delete questions when book is removed#4075Nateowami wants to merge 1 commit into
Nateowami wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4075 +/- ##
=======================================
Coverage 81.09% 81.09%
=======================================
Files 666 666
Lines 43263 43269 +6
Branches 7061 7087 +26
=======================================
+ Hits 35085 35090 +5
Misses 7013 7013
- Partials 1165 1166 +1 ☔ View full report in Codecov by Harness. |
Nateowami
marked this pull request as ready for review
August 28, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync logic now looks a bit odd with questions being archived and notes being deleted, but I think that actually makes sense because questions are only present in SF, so their deletion is destructive, whereas notes are also present in PT. I'm assuming we're essentially removing the notes from SF, but PT still has them, while the deletion of questions was permanently deleting them from a user's perspective (though I'm guessing ShareDB still had the ops).
Long term it would be nice to have a "deleted" state in SF, in addition to the archive state, and it would make more sense to put them there. In the meantime though, this makes more sense than removing them entirely.
This change is