Skip to content

SF-3820 Fix race condition when viewing tabs that use the editor#3981

Open
pmachapman wants to merge 2 commits into
masterfrom
fix/SF-3820
Open

SF-3820 Fix race condition when viewing tabs that use the editor#3981
pmachapman wants to merge 2 commits into
masterfrom
fix/SF-3820

Conversation

@pmachapman

@pmachapman pmachapman commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes a race condition that can cause the editor to not display under certain circumstances, particularly when viewing history.

I also took the opportunity to fix a bug I noticed while debugging this issue where a massive amount of CPU cycles were being consumed by formatDate when there were many items in the history dropdown. I fixed this by making the filter that contained the logic pure, but to ensure it updates when the locale changes, the locale is not passed to the filter.


This change is Reviewable

@pmachapman pmachapman added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Jul 6, 2026
@pmachapman pmachapman temporarily deployed to screenshot_diff July 6, 2026 23:19 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.03%. Comparing base (0be7d55) to head (efff7c8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../editor/editor-history/editor-history.component.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3981   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         645      645           
  Lines       41463    41464    +1     
  Branches     6750     6731   -19     
=======================================
+ Hits        33600    33601    +1     
- Misses       6755     6767   +12     
+ Partials     1108     1096   -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant