Kubernetes monolith#932
Conversation
ddaspit
left a comment
There was a problem hiding this comment.
It seems simple enough. Have we gotten any feedback from LTOps on the CPU and memory limits?
@ddaspit reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Still talking to Greg. It looks like memory is the place we should try to use as little as possible. Greg is chill with there being no limits on the CPU resources (which I actually already removed as per his request last month). He has OK'd the values in this PR as a good starting place and says we can monitor it. |
a4a749c to
b457229
Compare
|
Alright, I've tested this now more completely. Here's how I've tested it:
@ddaspit @pmachapman Anything else you think we should test? |
ddaspit
left a comment
There was a problem hiding this comment.
This covers everything I can think of.
@ddaspit made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
pmachapman
left a comment
There was a problem hiding this comment.
The only thing I can think of is to verify that files in the volume mounts are still present. The claims look correct for each volume, so they should be all OK.
@pmachapman reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
|
@pmachapman, wouldn't that be covered by being able to download a data file that was uploaded pre-monolith? Or am I not understanding? |
@Enkidu93 Yes, ignore me! |
b457229 to
39fff99
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
=======================================
Coverage 66.73% 66.73%
=======================================
Files 372 372
Lines 21687 21687
Branches 2771 2771
=======================================
Hits 14472 14472
Misses 6179 6179
Partials 1036 1036 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #922
I've tested this on internal-qa and it seems to be working fine, but I'd like to do a bit more testing.
This change is