Add script to remove temp/cache dirs#58
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a CommonJS cleanup script to remove core and extension temporary directories, updates ESLint and TypeScript lint includes to cover ChangesCleanup Script Infrastructure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
Add a 'why' if you can |
|
For simplification can we make sure this array is full of only strings? Then we don't need type checking and function executing below in a link. Code quote: () => {
/* eslint-disable no-nested-ternary */
let electronParent =
process.platform === 'win32' ? process.env.APPDATA : process.env.XDG_CONFIG_HOME;
if (!electronParent && process.env.HOME) {
electronParent =
process.platform === 'linux'
? path.join(process.env.HOME, '.config')
: process.platform === 'darwin'
? path.join(process.env.HOME, 'Library', 'Application Support')
: '';
}
/* eslint-enable no-nested-ternary */
return electronParent ? path.join(electronParent, 'Electron') : '';
}, |
jasonleenaylor
left a comment
There was a problem hiding this comment.
Had some suggestions.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on imnasnainaec).
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved.
|
Updated the Electron cache directory to match: paranext/paranext-core#2257 UPDATE: ... and reverted. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
Tested in Powershell on Windows 11. Not tested on Unix.
This change is
Summary by CodeRabbit
New Features
core:resetcommand to clean core caches and temp directories.Chores