TT-7623 fix: keep three-digit references on one line on mobile - #534
Draft
nabalone wants to merge 1 commit into
Draft
TT-7623 fix: keep three-digit references on one line on mobile#534nabalone wants to merge 1 commit into
nabalone wants to merge 1 commit into
Conversation
On the mobile Mark Verses screen, references with three-digit chapter or verse numbers (e.g. "119:10b-11a", "119:13-120:5e") wrapped onto two lines in the table, and the Edit Reference dialog title broke mid-number. Shrink the table's Start-Stop column to its own content (was a fixed 42%) and set the reference text to nowrap so it keeps the freed width on one line. In the dialog, drop the title to 1.1rem and keep the numeric range in a nowrap span so the whole title fits one line on a phone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TT-7623: on mobile, references with three-digit chapter/verse numbers wrapped onto two lines.
119:10b-11aand119:13-120:5ewrapped in the Reference column. The Start–Stop column was pinned to a fixed 42% width; it's now shrink-to-content, and the reference text isnowrap, so the reference keeps the freed width on a single line.Edit Reference for 124.7-425.2broke mid-number. The title is now1.1remand the numeric range sits in anowrapspan, so the whole title fits on one line on a phone.Both changes are scoped to the mobile Mark Verses components only.
Test plan
MarkVersesTableandEditReferenceDropdownwith three-digit Psalm 119 data at a 375px mobile viewport: every reference renders on one line with no horizontal overflow, and the dialog title fits one line with comfortable margin (~241–261px used of 311px available, even for the longest limit strings).npm run typecheck— passesnpx jest EditReferenceDropdown PassageDetailMarkVerses— 25 passed🤖 Generated with Claude Code