Fix LT-22508: text not enabled; text deletion issues#877
Merged
Conversation
jasonleenaylor
approved these changes
May 12, 2026
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
Src/xWorks/ConcDecorator.cs line 564 at r1 (raw file):
{ m_interestingTexts = InterestingTextsDecorator.GetInterestingTextList(Mediator, PropTable, m_services); m_interestingTexts.InterestingTextsChanged += m_interestingTexts_InterestingTextsChanged;
I know this was just moved and isn't new code, but we should verify that InterestingTextsDecorator.GetInterestingTextList can never return null. If it can we might need to return the guard above, and add a guard here. If it can't then reslove this without changes.
Collaborator
Author
|
InterestingTextsDecorator.GetInterestingTextList never returns null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt to fix https://jira.sil.org/browse/LT-22508. The problem was that some stale cached data was producing wrong results. I tried to fix this in InterlinearTextsRecordClerk, but this didn't always work. The new fix is in ConcDecorator.RemoveNotification. I had to not only clear the local cache data (m_interestingTexts) but also the data stored in InterestingTextsDecorator. I also had to replace m_interestingTexts with InterestingTextsList so that m_interestingTexts would be initialized at the appropriate time.
This change is