Skip to content

Fix LT-22508: text not enabled; text deletion issues#877

Merged
jtmaxwell3 merged 1 commit into
mainfrom
LT-22508b
May 12, 2026
Merged

Fix LT-22508: text not enabled; text deletion issues#877
jtmaxwell3 merged 1 commit into
mainfrom
LT-22508b

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Collaborator

@jtmaxwell3 jtmaxwell3 commented May 12, 2026

This is a second attempt to fix https://jira.sil.org/browse/LT-22508. The problem was that some stale cached data was producing wrong results. I tried to fix this in InterlinearTextsRecordClerk, but this didn't always work. The new fix is in ConcDecorator.RemoveNotification. I had to not only clear the local cache data (m_interestingTexts) but also the data stored in InterestingTextsDecorator. I also had to replace m_interestingTexts with InterestingTextsList so that m_interestingTexts would be initialized at the appropriate time.


This change is Reviewable

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).


Src/xWorks/ConcDecorator.cs line 564 at r1 (raw file):

				{
					m_interestingTexts = InterestingTextsDecorator.GetInterestingTextList(Mediator, PropTable, m_services);
					m_interestingTexts.InterestingTextsChanged += m_interestingTexts_InterestingTextsChanged;

I know this was just moved and isn't new code, but we should verify that InterestingTextsDecorator.GetInterestingTextList can never return null. If it can we might need to return the guard above, and add a guard here. If it can't then reslove this without changes.

@jtmaxwell3
Copy link
Copy Markdown
Collaborator Author

InterestingTextsDecorator.GetInterestingTextList never returns null.

@github-actions
Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 9s ⏱️ -29s
4 187 tests ±0  4 116 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 196 runs  ±0  4 125 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 37962f0. ± Comparison against base commit 3fd7827.

@jtmaxwell3 jtmaxwell3 merged commit 01a5f74 into main May 12, 2026
7 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22508b branch May 12, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants