Skip to content

LT-22657: Fix Word export guidewords - #1110

Merged
aror92 merged 5 commits into
mainfrom
LT-22657-guidewords
Aug 27, 2026
Merged

LT-22657: Fix Word export guidewords#1110
aror92 merged 5 commits into
mainfrom
LT-22657-guidewords

Conversation

@aror92

@aror92 aror92 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Quick Summary

  • Add IsClassified property to DictionaryConfigurationModel, modeled after the IsReversal property. Use this instead of Lexeme type to determine whether we are exporting a Classified Dictionary, since Configured Dictionary can also be a Lexeme type.
  • For guidewords in a Configured Dictionary export, use the first selected field in Dictionary Configuration of type Headword, Lexeme Form, or Citation Form.
  • Fixes #LT-22657.

Quick Summary

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md.
  • Builds & tests pass locally (or I've run the CI-style build via build.ps1, test.ps1, or MSBuild).
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate (no nested AGENTS.md under Src/xWorks; Src/AGENTS.md unaffected).
  • I have considered all comments from an AI code reviewer (such as [Devin]https://app.devin.ai/review/sillsdev/FieldWorks/pull/####)

This change is Reviewable

- Add IsClassified property to DictionaryConfigurationModel,
modeled after the IsReversal property. Use this instead of
Lexeme type to determine whether we are exporting a
Classified Dictionary, since Configured Dictionary can also
be a Lexeme type.

- For guidewords in a Configured Dictionary export, use the
first selected field in Dictionary Configuration of type
Headword, Lexeme Form, or Citation Form.

Change-Id: I32cf4e55ff96c2536d3590efbbf7c55b422aa3a2
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

Comment hygiene (advisory)

2 comment-style violation(s) in the lines this branch adds since origin/main.
Advisory only -- no check fails on these, and the same violations appear as inline warnings on the Files changed tab.

File Category Comment
Src/xWorks/LcmWordGenerator.cs:2936 comment-line-too-long 100 columns (max 98): <returns>A list of the full style names for the runs that should be...
Src/xWorks/LcmWordGenerator.cs:2965 comment-too-long 233 chars (budget 200): Configured Dictionary entries are based on either Headword, Lexeme...

Fix them per .claude/skills/fieldworks-code-commenting/SKILL.md.
Running .\build.ps1 -CommentHygiene (or .\test.ps1 -CommentHygiene) enforces them locally, and
re-wraps over-wide lines and repairs non-ASCII punctuation as it goes.

Change-Id: I7891edfc8310dd7f439b680bf2678bd0cd081559
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 34s ⏱️ -18s
5 863 tests +2  5 782 ✅ +2  81 💤 ±0  0 ❌ ±0 
5 872 runs  +2  5 791 ✅ +2  81 💤 ±0  0 ❌ ±0 

Results for commit 11a0bf3. ± Comparison against base commit b8f5463.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.35%. Comparing base (b8f5463) to head (11a0bf3).

Files with missing lines Patch % Lines
Src/xWorks/LcmWordGenerator.cs 57.14% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   38.35%   38.35%           
=======================================
  Files        1507     1507           
  Lines      350617   350629   +12     
  Branches    40298    40303    +5     
=======================================
+ Hits       134471   134494   +23     
+ Misses     186916   186902   -14     
- Partials    29230    29233    +3     
Files with missing lines Coverage Δ
Src/xWorks/DictionaryConfigurationModel.cs 84.57% <100.00%> (+0.50%) ⬆️
Src/xWorks/WordStylesGenerator.cs 41.87% <ø> (ø)
Src/xWorks/LcmWordGenerator.cs 41.46% <57.14%> (+0.39%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aror92 added 3 commits August 26, 2026 11:13
Change-Id: I32235361361c6e5656ac1535405b03d3816f21f1
Change-Id: If236f1874f2f17e33c43b7f52d87d0581c3ef64f
Change-Id: I550eeef49f66bc7483181785a351d9f79561745a
@aror92
aror92 marked this pull request as ready for review August 27, 2026 00:21

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@thejambi reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on aror92).

@aror92
aror92 merged commit 9a8a9b2 into main Aug 27, 2026
9 checks passed
@aror92
aror92 deleted the LT-22657-guidewords branch August 27, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants