LT-22657: Fix Word export guidewords - #1110
Conversation
- Add IsClassified property to DictionaryConfigurationModel, modeled after the IsReversal property. Use this instead of Lexeme type to determine whether we are exporting a Classified Dictionary, since Configured Dictionary can also be a Lexeme type. - For guidewords in a Configured Dictionary export, use the first selected field in Dictionary Configuration of type Headword, Lexeme Form, or Citation Form. Change-Id: I32cf4e55ff96c2536d3590efbbf7c55b422aa3a2
Comment hygiene (advisory)2 comment-style violation(s) in the lines this branch adds since
Fix them per |
Change-Id: I7891edfc8310dd7f439b680bf2678bd0cd081559
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
=======================================
Coverage 38.35% 38.35%
=======================================
Files 1507 1507
Lines 350617 350629 +12
Branches 40298 40303 +5
=======================================
+ Hits 134471 134494 +23
+ Misses 186916 186902 -14
- Partials 29230 29233 +3
🚀 New features to boost your workflow:
|
Change-Id: I32235361361c6e5656ac1535405b03d3816f21f1
Change-Id: If236f1874f2f17e33c43b7f52d87d0581c3ef64f
Change-Id: I550eeef49f66bc7483181785a351d9f79561745a
thejambi
left a comment
There was a problem hiding this comment.
@thejambi reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on aror92).
Quick Summary
Quick Summary
CI-ready checklist
.github/commit-guidelines.md.build.ps1,test.ps1, or MSBuild).Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate (no nested AGENTS.md under Src/xWorks; Src/AGENTS.md unaffected).This change is