rust(feat): sift cli get assets - #731
Merged
Merged
Conversation
Brandon-Shippy
changed the title
Brandon-Shippy
marked this pull request as ready for review
August 18, 2026 21:47
Brandon-Shippy
requested review from
alexluck-sift,
solidiquis,
tsift and
wei-qlu
August 18, 2026 21:47
solidiquis
reviewed
Aug 19, 2026
| let ListAssetsResponse { assets, .. } = AssetServiceClient::new(grpc_channel) | ||
| .list_assets(ListAssetsRequest { | ||
| filter: args.filter.unwrap_or_default(), | ||
| order_by: "modified_date desc".to_string(), |
Collaborator
There was a problem hiding this comment.
Should this be exposed as an option
| }, | ||
| }; | ||
|
|
||
| const ASSET_ID_CHAR_LENGTH_WHITESPACE_LENGTH: usize = 38; |
Collaborator
There was a problem hiding this comment.
We should use an ASCII table crate instead
| } | ||
|
|
||
| #[derive(clap::Args)] | ||
| pub struct GetAssetArgs { |
Collaborator
There was a problem hiding this comment.
We will be using these in a lot of other get subcommands so this should be a reusable struct that we flatten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
sift-cli get assetfor listing assets. Returns in a table by default with hyperlinks to the asset in explore. By default we list out the most recent 50 assets bymodified_ondateIt has a few flags:
-
--filtertakes a CEL expression-
--limitlets you edit how many rows you get back-
--output-formatlets you determine the output format, current flags are text and jsonVerification