fix: correct group prefix in SAML groups ACL example#623
Open
ohauer wants to merge 1 commit into
Open
Conversation
The AccessPolicy example in use-saml-groups-in-kubernetes.mdx used 'groups/group1' (plural) as the user group reference prefix, but the correct prefix is 'group/group1' (singular). This matches the Omni source code constant GroupPrefix = "group/" and is consistent with the cluster group references in the same example which already use the correct 'group/' prefix. Signed-off-by: Olli Hauer <ohauer@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AccessPolicy example in
use-saml-groups-in-kubernetes.mdxusedgroups/group1(plural) as the user group reference prefix, but the correct prefix isgroup/group1(singular).This matches the Omni source code constant
GroupPrefix = "group/"and is consistent with the cluster group references in the same example which already use the correctgroup/prefix.The incorrect prefix causes a silent failure:
strings.HasPrefix("groups/group1", "group/")returns false (the 5th character issnot/), so the entry is treated as a literal user identity string rather than a group reference. No user will ever match this identity, resulting in the rule having no effect.