Fix for cook results transform offset#366
Open
sorafrostfire wants to merge 1 commit into
Open
Conversation
The root problem is that when creating an HDA actor in Unreal and then transforming it and THEN cooking, the cook results will be offset by an amount equal to the transform done after the actor was created It appears that the HoudiniAssetComponent does not get notified when the transform changes due to the bWantsOnUpdateTransform flag being false. Furthermore, even if this flag is true, we don't submit the updated transform to Houdini unless we've done one or more cooks. Setting the flag to default to true and removing the cook count check fixes the original issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root problem is that when creating an HDA actor in Unreal and then transforming it and THEN cooking, the cook results will be offset by an amount equal to the transform done after the actor was created
It appears that the HoudiniAssetComponent does not get notified when the transform changes due to the bWantsOnUpdateTransform flag being false.
Furthermore, even if this flag is true, we don't submit the updated transform to Houdini unless we've done one or more cooks.
Setting the flag to default to true and removing the cook count check fixes the original issue