ui: unify the folder-location picker across add/accept flows#55
Open
grigorii-horos wants to merge 1 commit into
Open
ui: unify the folder-location picker across add/accept flows#55grigorii-horos wants to merge 1 commit into
grigorii-horos wants to merge 1 commit into
Conversation
The three ways to choose where a folder lives — app sandbox, a device folder (All Files Access), and a SAF tree — were each rendered with different controls, so the same decision looked unrelated in each place. Extract a single FolderLocationPicker that presents all three as uniform radio cards (SAF Android-only; the device card prompts for All Files Access when it isn't granted yet) and use it in both AddFolderModal and AcceptFolderModal. Removes the now-dead bespoke picker styles from both screens. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The three ways to choose where a folder lives — app sandbox, a device folder (All Files Access), and a SAF tree — were each rendered with different controls, so the same decision looked unrelated in Add folder vs Accept folder.
Extract a single
FolderLocationPickerthat presents all three as uniform radio cards:Used in both
AddFolderModalandAcceptFolderModal; removes the now-dead bespoke picker styles from both screens.Test
tsc --noEmit✅🤖 Generated with Claude Code