fix: resolve existing placeholders when merge fields are registered after load#133
Merged
Conversation
|
🎉 This PR is included in version 2.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a merge field directly on the service (mergeFields.register) updates the registry but nothing re-resolves clips that already contain the placeholder — the canvas keeps showing literal {{ braces }} until the clip re-renders for an unrelated reason (e.g. selecting it routes through the toolbar's resolve path).
Adds Edit.refreshMergeFields(): re-runs load-time placeholder detection over the document, updates clip bindings, and resolves — the Resolved event drives the player reconciler and timeline repaint, the same mechanism SetMergeFieldCommand relies on. The document keeps placeholders; only the resolved view and bindings change.
Verified with a regression test (placeholder literal after load with no merge array; registered + refreshed → resolved on the resolved clip, document still holds the placeholder and serialises the merge entry). Full suite: 1814 tests pass, typecheck and lint clean.