ECTO-2770 - ECTO-2770 - Report the real purchase result when the moda… - #193
Merged
Conversation
…l is closed while installing
Jannik (qysp)
requested review from
Florian Büscher (FloBWer),
Copilot and
Marvin Sibbing (mappinnn)
July 31, 2026 12:39
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect purchase result reporting and unexpected reload behavior when the extension-store checkout modal is closed while a purchase/installation is still in progress, ensuring the UI/telemetry reflect the real purchase outcome and reloads happen only when appropriate.
Changes:
- Introduces modal instance tracking (
purchaseId) and adds a “reload required” notification instead of auto-reloading when the purchase outlives the modal. - Adjusts cancellation behavior so closing a submitted purchase modal doesn’t falsely report failure/cancellation.
- Adds/extends unit tests to cover modal-closed-in-flight scenarios and updates snippets for the new notification text.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Resources/app/administration/src/module/sw-extension-store/store/extension-store-purchase-confirmation.store.ts | Adds purchaseId, reload-required notification, and updated confirm/cancel behavior to avoid incorrect reload/result reporting. |
| src/Resources/app/administration/src/module/sw-extension-store/store/extension-store-purchase-confirmation.store.spec.ts | Adds tests for in-flight modal closing, reload offer notification, and correct telemetry behavior. |
| src/Resources/app/administration/src/module/sw-extension-store/snippet/en.json | Adds new snippet keys for “reload required” notification text. |
| src/Resources/app/administration/src/module/sw-extension-store/snippet/de.json | Adds German translations for the new “reload required” notification text. |
| src/Resources/app/administration/src/module/sw-extension-store/service/extension-store-channel.service.spec.ts | Updates router mock shape and adds a test ensuring purchase results are still published when the modal is closed during installation. |
Suppressed comments (1)
src/Resources/app/administration/src/module/sw-extension-store/store/extension-store-purchase-confirmation.store.ts:232
purchaseIdis documented as increasing with every opened modal, butopenErrorModal()opens a modal without incrementing it. If a previous purchase finishes later, it can incorrectly treat the error modal as “its own” (samepurchaseId+isOpen) and trigger reload/state updates unexpectedly.
this.closeModal();
this.onCancel = onCancel;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marvin Sibbing (mappinnn)
approved these changes
Aug 3, 2026
Florian Büscher (FloBWer)
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l is closed while installing