fix: config watcher: avoid excessive wakes - #417
Merged
Conversation
ethanpailes
force-pushed
the
fix-agressive-watch-logging
branch
from
August 21, 2026 22:45
7d4f615 to
3f7726b
Compare
This patch switches the config watcher from watching the nearest parent if one of the config file paths does not exist to polling for the existance of the files every 5s instead. Previously, if the config file didn't exist and the parent path changed frequently, we would wind up super agressively polling. In particular, when I accidentally passed -c /tmp/config.toml but config.toml did not exist, in just a few seconds I created 1.7 million log lines at a debug log level. That's way to much and shpool should never be that chatty. This gets us to chill out a little while still picking up new configs in a pretty reasonable amount of time.
ethanpailes
force-pushed
the
fix-agressive-watch-logging
branch
from
August 21, 2026 23:03
3f7726b to
db7ea58
Compare
maxhbooth
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
n/a just noticed this
AI Policy Ack
Ack
This PR was:
I wrote the core of the change and used gemini to get the tests passing, plus do some pre-post code review.
Description
This patch switches the config watcher from watching the nearest parent if one of the config file paths does not exist to polling for the existance of the files every 5s instead.
Previously, if the config file didn't exist and the parent path changed frequently, we would wind up super agressively polling. In particular, when I accidentally passed -c /tmp/config.toml but config.toml did not exist, in just a few seconds I created 1.7 million log lines at a debug log level. That's way to much and shpool should never be that chatty. This gets us to chill out a little while still picking up new configs in a pretty reasonable amount of time.