Dev/save game cubes loop on tick#129
Merged
Merged
Conversation
Prefer to infer lib declarations from (inferred) target
f76e638 to
8988cf1
Compare
shanedg
commented
May 24, 2026
| ], | ||
| // Preserve ESM imports and CommonJS requires as-is. | ||
| // Best reflects capabilities of bundlers. | ||
| "module": "preserve", |
Owner
Author
There was a problem hiding this comment.
needed in node 22 environment to resolve cypress failing with ReferenceError: exports is not defined in ES module scope:
Opening Cypress...
DevTools listening on ws://127.0.0.1:44143/devtools/browser/12d275a9-50c4-4823-a6f2-215f152846b4
(node:2846) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("file%3A///home/runner/.cache/Cypress/13.17.0/Cypress/resources/app/node_modules/ts-node/esm/transpile-only.mjs", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:2846) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Your configFile is invalid: /home/runner/work/trshcmpctr/trshcmpctr/client/cypress/cypress.config.ts
It threw an error when required, check the stack trace below:
ReferenceError: exports is not defined in ES module scope
at file:///home/runner/work/trshcmpctr/trshcmpctr/client/cypress/cypress.config.ts:2:23
at ModuleJob.run (node:internal/modules/esm/module_job:343:25)
at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:681:26)
at async loadFile (/home/runner/.cache/Cypress/13.17.0/Cypress/resources/app/node_modules/@packages/server/lib/plugins/child/run_require_async_child.js:106:14)
at async EventEmitter.<anonymous>
shanedg
commented
May 24, 2026
Comment on lines
-21
to
-24
| // Core definitions + DOM definitions | ||
| "lib": [ | ||
| "es5", | ||
| "dom" |
Owner
Author
There was a problem hiding this comment.
prefer to let lib declarations be inferred from compilerOptions.target (target is implied by module, which seems to be effectively es2020 with preserve)
shanedg
commented
May 24, 2026
Comment on lines
-34
to
-35
| // Downlevel for Cypress test runner (?) | ||
| "target": "es5", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #128