Skip to content

Dev/save game cubes loop on tick#129

Merged
shanedg merged 11 commits into
mainfrom
dev/save-game-cubes-loop-on-tick
May 25, 2026
Merged

Dev/save game cubes loop on tick#129
shanedg merged 11 commits into
mainfrom
dev/save-game-cubes-loop-on-tick

Conversation

@shanedg

@shanedg shanedg commented May 21, 2026

Copy link
Copy Markdown
Owner

supersedes #128

@shanedg shanedg force-pushed the dev/save-game-cubes-loop-on-tick branch from f76e638 to 8988cf1 Compare May 24, 2026 21:28
],
// Preserve ESM imports and CommonJS requires as-is.
// Best reflects capabilities of bundlers.
"module": "preserve",

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed in node 22 environment to resolve cypress failing with ReferenceError: exports is not defined in ES module scope:

Opening Cypress...

DevTools listening on ws://127.0.0.1:44143/devtools/browser/12d275a9-50c4-4823-a6f2-215f152846b4
(node:2846) ExperimentalWarning: `--experimental-loader` may be removed in the future; instead use `register()`:
--import 'data:text/javascript,import { register } from "node:module"; import { pathToFileURL } from "node:url"; register("file%3A///home/runner/.cache/Cypress/13.17.0/Cypress/resources/app/node_modules/ts-node/esm/transpile-only.mjs", pathToFileURL("./"));'
(Use `node --trace-warnings ...` to show where the warning was created)
(node:2846) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Your configFile is invalid: /home/runner/work/trshcmpctr/trshcmpctr/client/cypress/cypress.config.ts

It threw an error when required, check the stack trace below:

ReferenceError: exports is not defined in ES module scope
    at file:///home/runner/work/trshcmpctr/trshcmpctr/client/cypress/cypress.config.ts:2:23
    at ModuleJob.run (node:internal/modules/esm/module_job:343:25)
    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:681:26)
    at async loadFile (/home/runner/.cache/Cypress/13.17.0/Cypress/resources/app/node_modules/@packages/server/lib/plugins/child/run_require_async_child.js:106:14)
    at async EventEmitter.<anonymous>

Comment on lines -21 to -24
// Core definitions + DOM definitions
"lib": [
"es5",
"dom"

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to let lib declarations be inferred from compilerOptions.target (target is implied by module, which seems to be effectively es2020 with preserve)

Comment on lines -34 to -35
// Downlevel for Cypress test runner (?)
"target": "es5",

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the problem but also not necessary

@shanedg shanedg marked this pull request as ready for review May 25, 2026 20:04
@shanedg shanedg merged commit ab7bfbe into main May 25, 2026
6 checks passed
@shanedg shanedg deleted the dev/save-game-cubes-loop-on-tick branch May 25, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant