Skip to content

perf: use after_create_commit for comment relaying #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatrixNeoKozak wants to merge 1 commit into from
Closed

perf: use after_create_commit for comment relaying #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/comment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

class Comment < ApplicationRecord
validates :author, :text, presence: true
after_commit { CommentRelayJob.perform_later(self) }
after_create_commit { CommentRelayJob.perform_later(self) }

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Broadcasting silently dropped for updates and destroys

after_create_commit only fires after an INSERT, so comment edits and deletes no longer enqueue CommentRelayJob. The app exposes both update and destroy actions via CommentsController, so any client subscribed to the "comments" ActionCable channel will continue to see stale data after a comment is edited or deleted. If real-time updates on create are the only required behaviour this is fine, but the PR description frames it purely as a performance improvement, which obscures the functional trade-off.

@justin808 justin808 Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to see updates for edits as well.

@greptile-apps greptile-apps Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this change introduces a regression. You should revert to after_commit (which fires on create, update, and destroy), or be explicit about the callbacks you want:

Suggested change
after_create_commit { CommentRelayJob.perform_later(self) }
after_create_commit { CommentRelayJob.perform_later(self) }
after_update_commit { CommentRelayJob.perform_later(self) }

Or more concisely, just keep the original:

after_commit { CommentRelayJob.perform_later(self) }

The original code was correct. The PR description's claim that after_create_commit is a "performance improvement" is only true if you intentionally want to drop update/delete relaying — which you don't. This PR should not be merged as-is.

end