perf: use after_create_commit for comment relaying by MatrixNeoKozak · Pull Request #766 · shakacode/react-webpack-rails-tutorial

MatrixNeoKozak · 2026-06-11T13:07:58Z

Optimizes the Comment model by changing after_commit to after_create_commit. This ensures the CommentRelayJob is only triggered upon the creation of a new comment, avoiding unnecessary broadcast operations when existing comments are updated. This improves system efficiency and reduces unnecessary WebSocket traffic. Closes #0

Summary by CodeRabbit

Chores
- Optimized comment relay processing timing to improve efficiency and accuracy.

github-actions · 2026-06-11T13:08:09Z

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

`+review-app-deploy`

Deploy your PR branch for testing.

`+review-app-delete`

Remove the review app when done.

`+review-app-help`

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

coderabbitai · 2026-06-11T13:08:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1b2251d-f195-4eaa-8238-2f56c29f44ab

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd3cbd and 2a867db.

📒 Files selected for processing (1)

app/models/comment.rb

Walkthrough

The Comment model's background job callback is changed from after_commit to after_create_commit, restricting CommentRelayJob enqueuing to comment creation only rather than all commit operations.

Changes

Comment Relay Job Trigger

Layer / File(s)	Summary
Comment create callback `app/models/comment.rb`	`CommentRelayJob.perform_later(self)` callback narrowed from `after_commit` to `after_create_commit`, limiting job enqueuing to comment creation commits only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'perf: use after_create_commit for comment relaying' directly describes the main change: replacing after_commit with after_create_commit for the comment relay callback to improve performance.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-06-11T13:10:15Z

Greptile Summary

This PR swaps after_commit for after_create_commit on the Comment model so that CommentRelayJob (which broadcasts comments over ActionCable) is only enqueued when a comment is first created, not on every subsequent commit.

Behavioral regression on updates: CommentsController exposes update and edit actions, meaning comments can be edited. With after_commit, edits triggered a broadcast so all WebSocket subscribers would see the new text immediately. With after_create_commit, comment edits and destroys will never enqueue the job, leaving connected clients with stale comment data.
Orphaned guard in CommentRelayJob: The unless comment.destroyed? guard was originally needed because after_commit also fired on destroy. That scenario can no longer occur with after_create_commit, so the guard becomes effectively dead code.

Confidence Score: 3/5

The change silently drops ActionCable broadcasts for comment edits and deletes, leaving connected clients with stale data; merging as-is would regress real-time update behavior.

Switching to after_create_commit removes broadcast coverage for update and destroy operations that the controller actively exposes. WebSocket subscribers will no longer receive notifications when a comment is edited or deleted, which is a present behavioral regression rather than a theoretical one.

app/models/comment.rb — the callback change and its interaction with the existing update/destroy actions needs a second look before merging.

Important Files Changed

Filename	Overview
app/models/comment.rb	Changed `after_commit` to `after_create_commit`, which drops ActionCable broadcasting for comment updates and destroys — a real behavioral change given the app has update/destroy actions.

Sequence Diagram

sequenceDiagram
    participant Client
    participant CommentsController
    participant Comment
    participant CommentRelayJob
    participant ActionCable

    Note over Comment,ActionCable: BEFORE (after_commit — fires on create, update, destroy)
    Client->>CommentsController: POST /comments (create)
    CommentsController->>Comment: save
    Comment->>CommentRelayJob: perform_later(self) [after create commit]
    CommentRelayJob->>ActionCable: broadcast "comments"

    Client->>CommentsController: PATCH /comments/:id (update)
    CommentsController->>Comment: update(...)
    Comment->>CommentRelayJob: perform_later(self) [after update commit]
    CommentRelayJob->>ActionCable: broadcast "comments"

    Note over Comment,ActionCable: AFTER (after_create_commit — fires on create only)
    Client->>CommentsController: POST /comments (create)
    CommentsController->>Comment: save
    Comment->>CommentRelayJob: perform_later(self) [after create commit]
    CommentRelayJob->>ActionCable: broadcast "comments"

    Client->>CommentsController: PATCH /comments/:id (update)
    CommentsController->>Comment: update(...)
    Note over Comment: No callback fires — subscribers not notified

_{Reviews (1): Last reviewed commit: "perf: use after_create_commit for commen..." | Re-trigger Greptile}

greptile-apps · 2026-06-11T13:10:19Z

 class Comment < ApplicationRecord
  validates :author, :text, presence: true
-  after_commit { CommentRelayJob.perform_later(self) }
+  after_create_commit { CommentRelayJob.perform_later(self) }


Broadcasting silently dropped for updates and destroys

after_create_commit only fires after an INSERT, so comment edits and deletes no longer enqueue CommentRelayJob. The app exposes both update and destroy actions via CommentsController, so any client subscribed to the "comments" ActionCable channel will continue to see stale data after a comment is edited or deleted. If real-time updates on create are the only required behaviour this is fine, but the PR description frames it purely as a performance improvement, which obscures the functional trade-off.

we want to see updates for edits as well.

Then this change introduces a regression. You should revert to after_commit (which fires on create, update, and destroy), or be explicit about the callbacks you want:

Suggested change

after_create_commit { CommentRelayJob.perform_later(self) }

after_create_commit { CommentRelayJob.perform_later(self) }

after_update_commit { CommentRelayJob.perform_later(self) }

Or more concisely, just keep the original:

after_commit { CommentRelayJob.perform_later(self) }

The original code was correct. The PR description's claim that after_create_commit is a "performance improvement" is only true if you intentionally want to drop update/delete relaying — which you don't. This PR should not be merged as-is.

justin808 · 2026-07-08T22:40:34Z

we want to see updates for edits and creates.

github-actions · 2026-07-08T22:41:00Z

✅ Review App Deleted

Review app for PR #766 is deleted

🎮 Control Plane Console
📋 View Workflow Logs

perf: use after_create_commit for comment relaying

2a867db

greptile-apps Bot reviewed Jun 11, 2026

View reviewed changes

coderabbitai Bot approved these changes Jun 11, 2026

View reviewed changes

justin808 closed this Jul 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: use after_create_commit for comment relaying#766

perf: use after_create_commit for comment relaying#766
MatrixNeoKozak wants to merge 1 commit into
shakacode:masterfrom
MatrixNeoKozak:fix/improvement-1781183275607

MatrixNeoKozak commented Jun 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 11, 2026

Uh oh!

greptile-apps Bot Jun 11, 2026

Uh oh!

justin808 Jul 8, 2026

Uh oh!

greptile-apps Bot Jul 8, 2026

Uh oh!

justin808 commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	after_create_commit { CommentRelayJob.perform_later(self) }
	after_create_commit { CommentRelayJob.perform_later(self) }
	after_update_commit { CommentRelayJob.perform_later(self) }

Uh oh!

Conversation

MatrixNeoKozak commented Jun 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jun 11, 2026

🚀 Quick Review App Commands

+review-app-deploy

+review-app-delete

+review-app-help

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

greptile-apps Bot commented Jun 11, 2026

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

justin808 Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

justin808 commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Review App Deleted

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MatrixNeoKozak commented Jun 11, 2026 •

edited by coderabbitai Bot

Loading

`+review-app-deploy`

`+review-app-delete`

`+review-app-help`

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

github-actions Bot commented Jul 8, 2026 •

edited

Loading