src/login_nopam.c: Simplify some code

[alejandro-colomar]

---

Revisions:

v1b

• Rebase

$ git rd 
 1:  3bac26354724 =  1:  537b6a03a677 src/login_nopam.c: Remove string_match()
 2:  9edd0a0e727e !  2:  51b1f587df4a src/login_nopam.c: from_match(): Unify style of conditionals
    @@ src/login_nopam.c: static bool from_match (char *tok, const char *string)
        } else if (strcaseeq(tok, "LOCAL")) {   /* LOCAL: no dots */
                if (!strchr(string, '.'))
                        return true;
    --  } else if (   (!streq(tok, "") && tok[strlen(tok) - 1] == '.') /* network */
    +-  } else if (   strrspn_(tok, ".")  /* network */
     -             && strprefix(resolve_hostname(string), tok)) {
     -          return true;
    -+  } else if (!streq(tok, "") && tok[strlen(tok) - 1] == '.') {  /* network */
    ++  } else if (strrspn_(tok, ".")  /* network */
     +          if (strprefix(resolve_hostname(string), tok))
     +                  return true;
        }
 3:  fadafa8fa947 !  3:  36478c11ea60 src/login_nopam.c: from_match(): return directly in all cases
    @@ src/login_nopam.c: static bool from_match (char *tok, const char *string)
     -          if (!strchr(string, '.'))
     -                  return true;
     +          return !strchr(string, '.');
    -   } else if (!streq(tok, "") && tok[strlen(tok) - 1] == '.') {  /* network */
    +   } else if (strrspn_(tok, ".")  /* network */
     -          if (strprefix(resolve_hostname(string), tok))
     -                  return true;
     +          return !!strprefix(resolve_hostname(string), tok);
 4:  2f39983c89a1 !  4:  fd970d49750a src/login_nopam.c: Don't else after return
    @@ src/login_nopam.c: static bool from_match (char *tok, const char *string)
                return str_len > tok_len && strcaseeq(tok, string + str_len - tok_len);
     -  } else if (strcaseeq(tok, "LOCAL")) {   /* LOCAL: no dots */
     -          return !strchr(string, '.');
    --  } else if (!streq(tok, "") && tok[strlen(tok) - 1] == '.') {  /* network */
    +-  } else if (strrspn_(tok, ".")  /* network */
     -          return !!strprefix(resolve_hostname(string), tok);
        }
     +  if (strcaseeq(tok, "LOCAL"))  /* LOCAL: no dots */
     +          return !strchr(string, '.');
    -+  if (!streq(tok, "") && tok[strlen(tok) - 1] == '.')  /* network */
    ++  if (strrspn_(tok, ".")  /* network */
     +          return !!strprefix(resolve_hostname(string), tok);
        return false;
      }
 5:  320b5ddc98c3 =  5:  a3638b9f27a5 src/login_nopam.c: login_access(): Reduce scope of local variables
 6:  d6264edfdf72 =  6:  1244697a7ee2 src/login_nopam.c: login_access(): Move error handling earlier
 7:  1dbaed7b1ea3 =  7:  566fa2f5b140 src/login_nopam.c: login_access(): Reduce indentation
 8:  30c20ba4ca8c =  8:  d209643e619f src/login_nopam.c: login_access(): Use for instead of while loop
 9:  f999479e2bf9 =  9:  08befd50450d src/login_nopam.c: login_access(): Handle a match earlier
10:  2b5979522d4f = 10:  88841c86aab2 src/login_nopam.c: login_access(): Consistently use 'perm'
11:  dd0fd366ea1b = 11:  a2606232519e src/login_nopam.c: login_access(): Remove redundant comments
12:  3fe331f1e6a8 = 12:  7cc582ca3765 lib/, src/login_nopam.c: login_access(): Return bool

v1c

• Rebase

$ git rd -U0
 1:  537b6a03a677 =  1:  f69c95d33ba8 src/login_nopam.c: Remove string_match()
 2:  51b1f587df4a =  2:  942decabcfbc src/login_nopam.c: from_match(): Unify style of conditionals
 3:  36478c11ea60 =  3:  f07c4e45dac5 src/login_nopam.c: from_match(): return directly in all cases
 4:  fd970d49750a =  4:  4e05fdfd4daa src/login_nopam.c: Don't else after return
 5:  a3638b9f27a5 =  5:  f07fc5dd2223 src/login_nopam.c: login_access(): Reduce scope of local variables
 6:  1244697a7ee2 !  6:  b19a183417c6 src/login_nopam.c: login_access(): Move error handling earlier
    @@ src/login_nopam.c: login_access(const char *user, const char *from)
    -+          if (errno != ENOENT) {
    -+                  int err = errno;
    -+                  SYSLOG(LOG_ERR, "cannot open %s: %s", TABLE, strerror(err));
    -+          }
    ++          if (errno != ENOENT)
    ++                  SYSLOGE(LOG_ERR, "cannot open %s", TABLE);
    @@ src/login_nopam.c: login_access(const char *user, const char *from)
    --          int err = errno;
    --          SYSLOG(LOG_ERR, "cannot open %s: %s", TABLE, strerror(err));
    +-          SYSLOGE(LOG_ERR, "cannot open %s", TABLE);
 7:  566fa2f5b140 !  7:  8d80eddeb001 src/login_nopam.c: login_access(): Reduce indentation
    @@ src/login_nopam.c: login_access(const char *user, const char *from)
    -           }
    +                   SYSLOGE(LOG_ERR, "cannot open %s", TABLE);
 8:  d209643e619f =  8:  6aece11a1af2 src/login_nopam.c: login_access(): Use for instead of while loop
 9:  08befd50450d =  9:  b8f4f15154b1 src/login_nopam.c: login_access(): Handle a match earlier
10:  88841c86aab2 = 10:  ab5c21069395 src/login_nopam.c: login_access(): Consistently use 'perm'
11:  a2606232519e ! 11:  a13b22541367 src/login_nopam.c: login_access(): Remove redundant comments
    @@ src/login_nopam.c: login_access(const char *user, const char *from)
    -           if (errno != ENOENT) {
    +           if (errno != ENOENT)
12:  7cc582ca3765 = 12:  4004c5558149 lib/, src/login_nopam.c: login_access(): Return bool