Sync package-lock.json so npm ci passes - #3
Merged
Conversation
The new app (sarah-s-app-fri) pulled react/react-dom 19.2.8 and @datadog/vite-plugin 3.2.12, but the committed lockfile was left at older versions (partly from an earlier vite-plugin pin), so `npm ci` failed with "package.json and package-lock.json are not in sync" — which broke the Typecheck & lint check before it could run. Regenerated the lockfile with `npm install`; npm ci, typecheck, and lint all pass now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates
package-lock.jsonso it's in sync with the workspacepackage.jsons.Why
The
Typecheck & lintcheck on #2 failed at thenpm cistep:The newly-scaffolded app resolved newer versions than the committed lockfile carried (the lockfile had been left at
react 19.2.3/@datadog/vite-plugin 3.2.9-dev.0from an earlier debugging pin).npm ciis strict, so it aborted before typecheck ran.Fix
npm installto regenerate the lockfile. Verified locally:npm ci,npm run typecheck, andnpm run lintall pass.Note (follow-up, not this PR)
@datadog/vite-pluginis inconsistent across apps —apps/sarah-s-app-thu-…and the root pin3.2.9-dev.0(debugging leftover), while the other apps use^3.2.1. Worth harmonizing to one range later.