Add the plain website address to the protocol string table - #171
Merged
Merged
Conversation
The table carries twenty-two addresses under getsession.org but not the root, so a client that links the website itself -- an onboarding footer, an about screen -- has to hard-code the one address the table cannot give it, beside a call that reads the rest from here. Appended rather than inserted: the field list is alphabetical and `url_website` sorts last, which also leaves the struct layout of the existing fields untouched.
mpretty-cyro
force-pushed
the
feat/website-url
branch
from
September 21, 2026 21:16
5b9ed71 to
9b96a56
Compare
Bilb
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_protocol_stringscarries twenty-two addresses undergetsession.org—url_faq,url_download,url_support,url_terms_of_serviceand so on — but not the root. A client that links the website itself has to hard-code that one address beside a call that reads every other one from here, which is the case this closes.The bare address is already in use. The desktop client links it in its about view as both the href and the visible link text, and separately allowlists the bare host as official alongside
session.foundation,token.andstake.— so it is established there at two independent layers. It is also one of the four addresses Session 2.0 currently hard-codes; the other three are already in this table.Appended rather than inserted. The field list is alphabetical and
url_websitesorts afterurl_translate, so the two agree: the new field goes at the end of the struct and the offsets of the existing fields do not move.No trailing slash, matching every other value here.