Move unit tests behind the public API boundary - #468
Closed
ANONYMOUSZED-beep wants to merge 1 commit into
Closed
Conversation
Member
|
@ANONYMOUSZED-beep Did you use AI tooling to create this pull request? |
Collaborator
alejandro-vaz
self-requested a review
August 28, 2026 16:26
Author
|
Yes. I used AI-assisted development tooling to help prepare this pull request, and I reviewed the resulting changes before submitting it. I’m happy to provide any additional detail needed under the project’s contribution policy. |
Member
|
Sorry, we have a policy that does not allow that: https://book.servo.org/contributing/getting-started.html#ai-contributions |
Member
That's what I was reacting to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tests.rstotests/smallvec.rssmallvecthrough its public APIstd,serde, andbytesThis makes API export regressions visible to the test suite instead of compiling the tests as an internal crate module.
Closes #440
Validation
cargo +1.83.0-x86_64-pc-windows-gnu test(67 integration tests and 6 doctests passed)cargo +stable-x86_64-pc-windows-gnu test(67 integration tests and 6 doctests passed)cargo +nightly-x86_64-pc-windows-gnu fmt --all --checkcargo +nightly-x86_64-pc-windows-gnu test --all-features(78 integration tests and 6 doctests passed)cargo +nightly-x86_64-pc-windows-gnu bench --all-features --no-rungit diff --check