docs: Update configuration docs to redirect to module configuration#387
docs: Update configuration docs to redirect to module configuration#387exaby73 wants to merge 1 commit into
Conversation
marcelomendoncasoares
left a comment
marcelomendoncasoares
left a comment
There was a problem hiding this comment.
Only one minor question for clarification!
| serverpod_auth_idp: | ||
| nickname: auth | ||
| my_custom_module: | ||
| nickname: custom | ||
| ``` | ||
|
|
||
| This allows you to reference module classes as `module:auth:UserInfo` in your model files. See the [modules documentation](modules) for more information. | ||
| This allows you to reference module classes as `module:auth:AuthUser` in your model files. See the [modules documentation](modules) for more information. |
There was a problem hiding this comment.
Question: Will this work? Since AuthUser is declared under serverpod_auth_core, but exported from serverpod_auth_idp.
If this is true, we should also update the reference in the authentication docs to use module:serverpod_auth_idp:AuthUser and fix serverpod/serverpod#4492.
There was a problem hiding this comment.
Above a nickname is given so it's pointing to serverpod_auth_idp
There was a problem hiding this comment.
We should change the module referenced here to core, right? Since we already saw that it won't work due to the serverpod_auth_core models being exported in the serverpod_auth_ipd_server/core.dart. Unless we add the export to both the client and server central export file for the IDP package. What do you think?
|
Two things blocking this from progressing:
Happy to give it another pass once both are sorted. |
| - **Cloud storage (GCP/S3)**: [Uploading files](file-uploads) | ||
| - **Authentication**: [Authentication Setup](authentication/setup#storing-secrets) |
There was a problem hiding this comment.
Suggestion: two small adjustments to the bullet. The file-uploads page also documents Cloudflare R2, so naming it makes the pointer accurate. Matching the link text to the actual heading on the auth page ("Storing Secrets") reads more cleanly than "Authentication Setup".
| - **Cloud storage (GCP/S3)**: [Uploading files](file-uploads) | |
| - **Authentication**: [Authentication Setup](authentication/setup#storing-secrets) | |
| - **Cloud storage**: see [Uploading files](file-uploads) for GCP, AWS S3, and Cloudflare R2 secrets. | |
| - **Authentication**: see [Storing secrets](authentication/setup#storing-secrets) on the Authentication setup page. |
3 participants
Fixes: serverpod/serverpod#4731