Improve OAuth2 DSL (FuncDSL and DSL)#1452
Merged
Merged
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds first-class OAuth2 authentication helpers to the fluent DSL (including OAuth2-specific endpoints configuration) and validates them via new functional DSL tests.
Changes:
- Added new
DSL.oauth2(...)overloads to support explicit OAuth2 endpoints and full OAuth2 policy customization. - Exposed the new OAuth2 overloads through
FuncDSL. - Added JUnit coverage verifying both the convenience overload and the full-builder overload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/DSL.java | Introduces new OAuth2 overloads, including OAuth2 endpoints configuration and a full-policy builder entry point |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java | Re-exports the new OAuth2 overloads for the functional DSL layer |
| experimental/fluent/func/src/test/java/io/serverlessworkflow/fluent/func/FuncDSLOAuth2Test.java | Adds tests asserting OAuth2 properties (authority, grant, client, endpoints, scopes/audiences) are properly set |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
13 tasks
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Allow to configure the full OAuth2 spec with DSL.
Special notes for reviewers:
Additional information (if needed):
Closes #1450