fix: Convert source output from json to yaml#175
Merged
ricardozanini merged 1 commit intoJun 10, 2026
Conversation
lornakelly
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the side panel “Source” rendering in the diagram editor from JSON to YAML, along with corresponding styling and test updates.
Changes:
- Replace the Source block renderer from
JsonField+JSON.stringifytoYamlField+js-yamlserialization. - Rename sidebar CSS classes from
*-json-*to*-yaml-*. - Update
NodeDetailsViewtests to assert YAML output and YAML-specific class names.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/tests/side-panel/NodeDetailsView.test.tsx | Updates unit test expectations to use YAML output and YAML CSS selectors. |
| packages/serverless-workflow-diagram-editor/src/side-panel/SidePanel.css | Renames JSON-related CSS selectors/comments to YAML equivalents. |
| packages/serverless-workflow-diagram-editor/src/side-panel/NodeDetailsView.tsx | Switches Source serialization to YAML via js-yaml and swaps JsonField for YamlField. |
| packages/serverless-workflow-diagram-editor/src/side-panel/Fields.tsx | Renames JsonField component to YamlField and updates class names/props accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: lornakelly <lornakelly88@gmail.com>
lornakelly
force-pushed
the
101/source-yaml-fix
branch
from
edbce2c to
b37eae3
Compare
lornakelly
requested review from
cheryl7114,
fantonangeli,
handreyrc and
kumaradityaraj
cheryl7114
approved these changes
Jun 9, 2026
handreyrc
approved these changes
Jun 9, 2026
kumaradityaraj
approved these changes
Jun 10, 2026
Contributor
Author
|
@ricardozanini please merge when you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #101
Summary
Change JSON output under
Sourcesection of sidepanel to display yaml instead based on feedback as YAML is the first-class citizen in the spec.Changes
yaml.dumpSee request: #168 (comment)