feat: Add node containers and styles#172
Merged
ricardozanini merged 1 commit intoJun 9, 2026
Merged
Conversation
Signed-off-by: lornakelly <lornakelly88@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the diagram editor’s node visuals by splitting leaf vs container node configs, introducing dedicated container node rendering/styling, and adjusting layout defaults to match the new UI.
Changes:
- Split node visual config into
leafNodeConfigMapandcontainerNodeConfigMap, and addgetNodeVisualConfig. - Introduce new
LeafNodeContent/ContainerNodeContentrendering and refresh node/badge styling. - Update
DEFAULT_NODE_SIZEand adjust tests accordingly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/taskNodeConfig.ts | Adds container-node configs and a shared resolver for node visual config. |
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx | Splits node rendering into leaf/container components; updates badge behavior. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css | Adds container node styling and refreshes leaf node/badge styles. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/autoLayout.ts | Updates default node dimensions. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/nodes/taskNodeConfig.test.ts | Expands config tests to cover container nodes and resolver behavior. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/nodes/Nodes.test.tsx | Updates node rendering expectations and adds container badge assertions. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/diagram/autoLayout.integration.test.ts | Updates expected default node size. |
| packages/serverless-workflow-diagram-editor/tests/react-flow/diagram/diagramBuilder.test.ts | Moves CATCH_CONTAINER_NODE_TYPE import to the new source of truth. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/diagramBuilder.ts | Moves CATCH_CONTAINER_NODE_TYPE import to the new source of truth. |
| packages/serverless-workflow-diagram-editor/src/side-panel/SidePanel.tsx | Uses getNodeVisualConfig instead of leaf-only config mapping. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.tsx | Formatting-only change (line wrapping). |
| .changeset/node-container-styling.md | Publishes a minor release note for styling updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cheryl7114
approved these changes
Jun 9, 2026
Contributor
Author
|
@ricardozanini can you please merge when you get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
Summary
Add container node types (Do, For, Fork, TryCatch, Try and Catch) into styled nodes
Changes
competeandwhilecallnode (replaced icon badge)Example screenshots: