Fix parse_auth_type missing "none" clause for Elasticsearch sinks#2124
Open
juanherrera-jpy wants to merge 2 commits intosequinstream:mainfrom
Open
Fix parse_auth_type missing "none" clause for Elasticsearch sinks#2124juanherrera-jpy wants to merge 2 commits intosequinstream:mainfrom
juanherrera-jpy wants to merge 2 commits intosequinstream:mainfrom
Conversation
Config export produces `auth_type: none` for Elasticsearch sinks without authentication, but config import fails because parse_auth_type/1 doesn't handle the "none" value. Add the missing clause. Closes sequinstream#2123 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dosubot
Bot
added
size:M
RTLS
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
wondering if we should change nil to map to :none as well - though that is a breaking change
Author
There was a problem hiding this comment.
nil does auth_type none as well, it needs to be pointed out that this might breaking some setups.
When parse_auth_type is nil do authorization type none as well.
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_auth_type("none")clause inSequin.Transformsthat causedconfig applyto fail with aFunctionClauseErrorwhen importing Elasticsearch sinks with no authenticationauth_type: "none"via YAML configCloses #2123
Test plan
mix test test/sequin/yaml_loader_test.exs— new test forauth_type: "none"should passauth_type: none, then re-import — should succeed without errors🤖 Generated with Claude Code