feat(multitask): forward max_time_spotoptim to SpotOptim#209
Merged
Conversation
ConfigMulti/ConfigEntsoe (sf2-safe >= 21.1.0) carry a new max_time_spotoptim field: a wall-clock budget for the surrogate search in minutes. SpotOptimStrategy now forwards it as SpotOptim's max_time, so the search stops at n_trials_spotoptim evaluations or the time limit, whichever comes first. Unset/None forwards nothing (read via getattr, so older sf2-safe configs keep working). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
21.2.0 carries the max_time_spotoptim config field consumed by SpotOptimStrategy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
🎉 This PR is included in version 7.1.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpotOptimStrategynow forwards the newConfigMulti/ConfigEntsoefieldmax_time_spotoptim(sf2-safe 21.2.0; wall-clock minutes, defaultNone= no limit) as SpotOptim'smax_time, so the surrogate search stops atn_trials_spotoptimevaluations or the time limit, whichever comes first. Read viagetattr, so older configs keep working. Bumps the sf2-safe pin to>=21.2.0,<22.Verified locally: full suite (1167 passed, incl. the team4 consumer-contract tests against the released 21.2.0), ruff, quartodoc + full quarto render.
🤖 Generated with Claude Code