fix: use premiumFeatureList for super group and broadcast channel features#306
Open
OnestarLee wants to merge 2 commits into
Open
fix: use premiumFeatureList for super group and broadcast channel features#306OnestarLee wants to merge 2 commits into
OnestarLee wants to merge 2 commits into
Conversation
…tures The server deprecated application_attributes flags (allow_super_group_channel, allow_broadcast_channel) in favor of premium_feature_list. This updates useAppFeatures hook to check premiumFeatureList for super_group_channel and broadcast_channel instead of applicationAttributes. https://claude.ai/code/session_01MNFZvqQGYiF4sB6rBggoxo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
========================================
Coverage 10.84% 10.84%
========================================
Files 360 360
Lines 9084 9084
Branches 2578 2442 -136
========================================
Hits 985 985
- Misses 8023 8098 +75
+ Partials 76 1 -75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAppFeatureshook에서 super group channel과 broadcast channel 기능 활성화 여부를 확인할 때applicationAttributes대신premiumFeatureList를 사용하도록 수정PremiumFeaturesenum에broadcast_channel추가application_attributes > allow_super_group_channel플래그가 더 이상 사용되지 않고premium_feature_list를 참조해야 함Changes
packages/uikit-utils/src/sendbird/attrs.ts:PremiumFeaturesenum에broadcast_channel추가packages/uikit-chat-hooks/src/common/useAppFeatures.ts:broadcastChannelEnabled와superGroupChannelEnabled를premiumFeatureList에서 확인하도록 변경packages/uikit-chat-hooks/src/__tests__/common/useAppFeatures.test.ts: 테스트 업데이트Test plan
Related
https://claude.ai/code/session_01MNFZvqQGYiF4sB6rBggoxo
Generated by Claude Code